You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Guosmilesmile (via GitHub)" <gi...@apache.org> on 2026/07/22 14:31:56 UTC

[PR] Build: bump Jackson from 2.15 to 2.18 to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Guosmilesmile opened a new pull request, #17336:
URL: https://github.com/apache/iceberg/pull/17336

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3639569523


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   Good. Let's remove and see.
   
   Also we might want to ask someone with more spark experience.
   Maybe @szehon-ho or @huaxingao?
   
   What do you think @szehon-ho or @huaxingao: If we change the relocated jackson version from 2.15.2 to 2.21.4, would that cause any issues for the users if the Spark test are green? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3668796824


##########
.github/trivyignore/kafka-connect-runtime.trivyignore:
##########
@@ -17,14 +17,17 @@
 #
 # Trivy ignore file for the Kafka Connect runtime distribution.
 #
-# The Kafka Connect runtime's own jackson-databind is already aligned to the
-# project version (2.22.x). The remaining finding comes from parquet-jackson,
-# which ships its own shaded copy of jackson-databind (relocated under
-# shaded.parquet.*). That copy cannot be upgraded independently of Apache
-# Parquet, and 1.17.1 still bundles a vulnerable version.
+# The Kafka Connect runtime's own jackson-core / jackson-databind are already
+# aligned to the project version (2.22.x). The remaining findings come from
+# parquet-jackson, which ships its own shaded copy of jackson-core /
+# jackson-databind (relocated under shaded.parquet.*). That copy cannot be
+# upgraded independently of Apache Parquet, and 1.17.1 still bundles
+# vulnerable versions.
 #
 # jackson-databind CVEs shaded into parquet-jackson, only fixed in jackson
 # >= 2.21.4 / 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
+# jackson-core CVE shaded into parquet-jackson, only fixed in jackson
+# >= 2.18.8 / 2.21.4 / 2.22.1.
 GHSA-r7wm-3cxj-wff9

Review Comment:
   we should look into cleaning these up too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5064888906

   Change spark jackson 2.21 to 2.18 to keep the smallest jump


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3643019695


##########
.github/trivyignore/spark-runtime-3.5.trivyignore:
##########
@@ -25,4 +25,3 @@
 # jackson-databind CVEs that are only fixed in jackson >= 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
-GHSA-r7wm-3cxj-wff9

Review Comment:
   Thanks for pointing it out. Also remove CVE-2026-54512 and CVE-2026-54513.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3643018520


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"

Review Comment:
   Right. Remove it from libs. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3640229815


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   each version of spark is using a different override right now
   - spark v3.5 is currently using [jackson215](https://github.com/apache/iceberg/blob/cd708ae33175fad24e0b4dc2f3395167662c1121/spark/v3.5/build.gradle#L33-L35)
   - spark v4.0 is currently using [jackson218](https://github.com/apache/iceberg/blob/cd708ae33175fad24e0b4dc2f3395167662c1121/spark/v4.0/build.gradle#L33-L35)
   - spark v4.1 is currently using [jackson221](https://github.com/apache/iceberg/blob/cd708ae33175fad24e0b4dc2f3395167662c1121/spark/v4.1/build.gradle#L33-L35)
   
   Looks like the CVE suggests `2.18.8` as the minimum version, https://github.com/advisories/GHSA-r7wm-3cxj-wff9
   
   Should we use that instead of 2.21? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3639433808


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   > If we do this, do we need the GHSA-r7wm-3cxj-wff9 in spark-runtime-3.5.trivyignore?
   
   Yes, so I remove GHSA-r7wm-3cxj-wff9 in spark-runtime-3.5.trivyignore.
   
   > Also, how sure are we that Spark works with a different fasterxml version?
   
   Good question. Since `com.fasterxml` is relocated to `org.apache.iceberg.shaded.com.fasterxml`(relocate 'com.fasterxml', 'org.apache.iceberg.shaded.com.fasterxml'), the Jackson copy included in the Iceberg runtime jar is isolated from Spark's own Jackson jars and should not override them.
   
   I verified dependency resolution for Spark 3.5 and it now resolves `jackson-core`, `jackson-databind`, and `jackson-module-scala_2.12` to 2.21.4. 
   
   However, that is not a full compatibility guarantee, so we should validate this with Spark 3.5 tests.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5057684510

   Thanks @Guosmilesmile!
   I haven't found this, and merged #17344 as a quick fix.
   
   Please rebase above the current as I like your better.
   
   Maybe we can even try to upgrade Spark 3.5 to the new version too. If that works that would be even better.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3639327046


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   Also, how sure are we that Spark works with a different fasterxml version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3669721671


##########
.github/trivyignore/kafka-connect-runtime.trivyignore:
##########
@@ -17,14 +17,17 @@
 #
 # Trivy ignore file for the Kafka Connect runtime distribution.
 #
-# The Kafka Connect runtime's own jackson-databind is already aligned to the
-# project version (2.22.x). The remaining finding comes from parquet-jackson,
-# which ships its own shaded copy of jackson-databind (relocated under
-# shaded.parquet.*). That copy cannot be upgraded independently of Apache
-# Parquet, and 1.17.1 still bundles a vulnerable version.
+# The Kafka Connect runtime's own jackson-core / jackson-databind are already
+# aligned to the project version (2.22.x). The remaining findings come from
+# parquet-jackson, which ships its own shaded copy of jackson-core /
+# jackson-databind (relocated under shaded.parquet.*). That copy cannot be
+# upgraded independently of Apache Parquet, and 1.17.1 still bundles
+# vulnerable versions.
 #
 # jackson-databind CVEs shaded into parquet-jackson, only fixed in jackson
 # >= 2.21.4 / 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
+# jackson-core CVE shaded into parquet-jackson, only fixed in jackson
+# >= 2.18.8 / 2.21.4 / 2.22.1.
 GHSA-r7wm-3cxj-wff9

Review Comment:
   I will raise a pr to fix it later



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3668945598


##########
.github/trivyignore/kafka-connect-runtime.trivyignore:
##########
@@ -17,14 +17,17 @@
 #
 # Trivy ignore file for the Kafka Connect runtime distribution.
 #
-# The Kafka Connect runtime's own jackson-databind is already aligned to the
-# project version (2.22.x). The remaining finding comes from parquet-jackson,
-# which ships its own shaded copy of jackson-databind (relocated under
-# shaded.parquet.*). That copy cannot be upgraded independently of Apache
-# Parquet, and 1.17.1 still bundles a vulnerable version.
+# The Kafka Connect runtime's own jackson-core / jackson-databind are already
+# aligned to the project version (2.22.x). The remaining findings come from
+# parquet-jackson, which ships its own shaded copy of jackson-core /
+# jackson-databind (relocated under shaded.parquet.*). That copy cannot be
+# upgraded independently of Apache Parquet, and 1.17.1 still bundles
+# vulnerable versions.
 #
 # jackson-databind CVEs shaded into parquet-jackson, only fixed in jackson
 # >= 2.21.4 / 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
+# jackson-core CVE shaded into parquet-jackson, only fixed in jackson
+# >= 2.18.8 / 2.21.4 / 2.22.1.
 GHSA-r7wm-3cxj-wff9

Review Comment:
   @Guosmilesmile do you mind following up with the items here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5109081692

   Im comfortable moving forward with this PR, thanks @Guosmilesmile for the fix and everyone for the review!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3662294961


##########
.github/trivyignore/spark-runtime-3.5.trivyignore:
##########
@@ -25,4 +25,3 @@
 # jackson-databind CVEs that are only fixed in jackson >= 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
-GHSA-r7wm-3cxj-wff9

Review Comment:
   Make sense. Remove the lines about jackson now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu merged PR #17336:
URL: https://github.com/apache/iceberg/pull/17336


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3642771783


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   This PR was originally meant to fix the CVEs for both Kafka and Spark together. The Kafka part has already been merged. As for the Spark part, I feel that if we can fix the vulnerability by bumping the jar version, that might be a cleaner approach than just suppressing it in spark-runtime-3.5.trivyignore. 
   That said, I'm happy to go with whatever the majority thinks is best here :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3659363517


##########
.github/trivyignore/spark-runtime-3.5.trivyignore:
##########
@@ -25,4 +25,3 @@
 # jackson-databind CVEs that are only fixed in jackson >= 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
-GHSA-r7wm-3cxj-wff9

Review Comment:
   looks like this file is now empty, and we can either remove it completely or keep only a skeleton. but we should remove the lines about jackson



##########
.github/trivyignore/spark-runtime-3.5.trivyignore:
##########
@@ -22,7 +22,3 @@
 # compatibility with Spark 3.5. Newer Spark lines (4.0, 4.1) align Jackson to a
 # fixed version instead of ignoring the finding.
 #

Review Comment:
   ```suggestion
   ```
   outdated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3642748038


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   > Do we actually need this bump?
   
   I agree. If we dont exercise this particular code path then lets not bump this and avoid potentially introducing new issues



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3642936471


##########
.github/trivyignore/spark-runtime-3.5.trivyignore:
##########
@@ -25,4 +25,3 @@
 # jackson-databind CVEs that are only fixed in jackson >= 2.18.8.
 CVE-2026-54512
 CVE-2026-54513
-GHSA-r7wm-3cxj-wff9

Review Comment:
   is this file still accurate after bumping jackson to 2.18.8?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3639628980


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   My previous submission has already removed the  GHSA-r7wm-3cxj-wff9 in spark-runtime-3.5.trivyignore.
   
   As for the rest, let's hear what others think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5105984356

   > I lean towards the upgrade. The current tests provide sufficient coverage to keep the compatibility risk low.
   
   I agree with this assessment. I think the reasoning to do a minimal 2.18.8 bump, despite Iceberg not using the code path in question, is the right call. We're minimizing the risk of surprise changes by not jumping to a much newer version, and we have CI as a backstop for correctness.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3641495087


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   Do we actually need this bump? The CVE (`GHSA-r7wm-3cxj-wff9`) is a DoS in Jackson's async/non-blocking parser, which isn't used on Iceberg's parsing paths (we use the blocking parser), and the jar is shaded — so it's not a reachable issue for us, just a scanner finding we already suppress.
   
   If we do want to fix it (e.g. to keep downstream scanners quiet), I'd lean toward `2.18.8`: it's the minimal patched version that clears the finding (Spark 4.0 ships it and needs no ignore), and it's the smallest jump from 3.5's native `2.15.2`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "nssalian (via GitHub)" <gi...@apache.org>.
nssalian commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5052711066

   @Guosmilesmile thanks for putting this fix. Seeing CI failures on this. Do you mind adding the description to the PR so the change rationale is clear? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5058208230

   > Thanks @Guosmilesmile! I haven't found this, and merged #17344 as a quick fix.
   > 
   > Please rebase above the current as I like your better.
   > 
   > Maybe we can even try to upgrade Spark 3.5 to the new version too. If that works that would be even better.
   
   @pvary Thank you very much for the reminder. I removed the "ignore" section for Spark, and aligned the 3.5 version with the 4.1 version by upgrading it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "Guosmilesmile (via GitHub)" <gi...@apache.org>.
Guosmilesmile commented on PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#issuecomment-5053454874

   > @Guosmilesmile thanks for putting this fix. Seeing CI failures in other PRs. Would be great to get this in. Do you mind adding the description to the PR so the change rationale is clear?
   
   OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3639323425


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson215.get()}"
-        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson215.get()}"
+        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-databind:${libs.versions.jackson221.get()}"
+        force "com.fasterxml.jackson.core:jackson-core:${libs.versions.jackson221.get()}"

Review Comment:
   If we do this, do we need the `GHSA-r7wm-3cxj-wff9` in spark-runtime-3.5.trivyignore?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [PR] Build: bump Jackson to fix CVE GHSA-r7wm-3cxj-wff9 [iceberg]

Posted by "manuzhang (via GitHub)" <gi...@apache.org>.
manuzhang commented on code in PR #17336:
URL: https://github.com/apache/iceberg/pull/17336#discussion_r3642937668


##########
spark/v3.5/build.gradle:
##########
@@ -30,9 +30,9 @@ configure(sparkProjects) {
   configurations {
     all {
       resolutionStrategy {
-        force "com.fasterxml.jackson.module:jackson-module-scala_${scalaVersion}:${libs.versions.jackson215.get()}"

Review Comment:
   jackson215 is unused now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org