You are viewing a plain text version of this content. The canonical link for it is here.
Posted to rampart-dev@ws.apache.org by ka...@apache.org on 2007/09/04 11:29:21 UTC
svn commit: r572591 - in /webservices/rampart/trunk/c/src/omxmlsec/openssl:
sign.c x509.c
Author: kaushalye
Date: Tue Sep 4 02:29:20 2007
New Revision: 572591
URL: http://svn.apache.org/viewvc?rev=572591&view=rev
Log:
Mem leak fixed
Modified:
webservices/rampart/trunk/c/src/omxmlsec/openssl/sign.c
webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c
Modified: webservices/rampart/trunk/c/src/omxmlsec/openssl/sign.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/openssl/sign.c?rev=572591&r1=572590&r2=572591&view=diff
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/openssl/sign.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/openssl/sign.c Tue Sep 4 02:29:20 2007
@@ -107,14 +107,17 @@
oxs_error(env, ERROR_LOCATION, OXS_ERROR_SIG_VERIFICATION_FAILED,"EVP_VerifyInit failed" );
return AXIS2_FAILURE;
}
- ret = EVP_VerifyUpdate(&md_ctx, oxs_buffer_get_data(input_buf, env), oxs_buffer_get_size(input_buf, env));
+ ret = EVP_VerifyUpdate(&md_ctx,
+ oxs_buffer_get_data(input_buf, env),
+ oxs_buffer_get_size(input_buf, env));
if(ret != 1) {
/*Error*/
oxs_error(env, ERROR_LOCATION, OXS_ERROR_SIG_VERIFICATION_FAILED,"EVP_VerifyUpdate failed" );
return AXIS2_FAILURE;
}
- ret = EVP_VerifyFinal(&md_ctx, oxs_buffer_get_data(sig_buf, env),
+ ret = EVP_VerifyFinal(&md_ctx,
+ oxs_buffer_get_data(sig_buf, env),
oxs_buffer_get_size(sig_buf, env),
pkey);
if(ret == 0){
@@ -126,12 +129,13 @@
oxs_error(env, ERROR_LOCATION, OXS_ERROR_SIG_VERIFICATION_FAILED,"Error occured while verifying the signature." );
status = AXIS2_FAILURE;
}else{
- /*SUCCESS. Det ar bra :-)*/
+ /*SUCCESS. */
AXIS2_LOG_INFO(env->log, "[openssl][sig] Signature verification SUCCESS " );
status = AXIS2_SUCCESS;
}
- return status;
+ EVP_MD_CTX_cleanup(&md_ctx);
+ return status;
}
Modified: webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c
URL: http://svn.apache.org/viewvc/webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c?rev=572591&r1=572590&r2=572591&view=diff
==============================================================================
--- webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c (original)
+++ webservices/rampart/trunk/c/src/omxmlsec/openssl/x509.c Tue Sep 4 02:29:20 2007
@@ -104,12 +104,10 @@
if (!in)
{
- /*oxs_error(env, ERROR_LOCATION, OXS_ERROR_DEFAULT,
- "Error reading the file %s", filename);*/
return AXIS2_FAILURE;
}
/*Read certificate*/
- PEM_read_bio_X509(in, cert,NULL,NULL);
+ PEM_read_bio_X509(in, cert, NULL, NULL);
if (-1 == BIO_reset(in) ){
return AXIS2_FAILURE;
@@ -123,6 +121,7 @@
{
return AXIS2_FAILURE;
}
+
return AXIS2_SUCCESS;
}