You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "wangxj3 (via GitHub)" <gi...@apache.org> on 2024/09/11 10:55:26 UTC
[PR] [Feature-16608]add Security Model [dolphinscheduler]
wangxj3 opened a new pull request, #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609
<!--Thanks very much for contributing to Apache DolphinScheduler, we are happy that you want to help us improve DolphinScheduler! -->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
This pull request is code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added dolphinscheduler-dao tests for end-to-end.*
- *Added CronUtilsTest to verify the change.*
- *Manually verified the change by testing locally.* -->
(or)
## Pull Request Notice
[Pull Request Notice](https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)
If your pull request contain incompatible change, you should also add it to `docs/docs/en/guide/upgrede/incompatible.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16608][Doc] Add Security Model [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS merged PR #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16608][Doc] Add Security Model [dolphinscheduler]
Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo commented on PR #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609#issuecomment-2351464010
By the way, I suggest you add a note in this following doc, the reporter should read our security model before submitting the security issues `https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/security.md`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16608][Doc] Add Security Model [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609#discussion_r1796960360
##########
docs/docs/en/security-model.md:
##########
@@ -0,0 +1,86 @@
+# Apache DolphinScheduler Security Model
Review Comment:
The `security.md` is not reflected in the document, which is a bug. I've create issue #16690 to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16608][Doc] Add Security Model [dolphinscheduler]
Posted by "wangxj3 (via GitHub)" <gi...@apache.org>.
wangxj3 commented on PR #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609#issuecomment-2357345573
> By the way, please add a note in this following doc, the reporter should read our security model before submitting the security issues `https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/security.md`
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16608][Doc] Add Security Model [dolphinscheduler]
Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609#discussion_r1796448315
##########
docs/docs/en/security-model.md:
##########
@@ -0,0 +1,86 @@
+# Apache DolphinScheduler Security Model
Review Comment:
It should be in the same directory as `security.md`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [Feature-16608][Doc] Add Security Model [dolphinscheduler]
Posted by "wangxj3 (via GitHub)" <gi...@apache.org>.
wangxj3 commented on code in PR #16609:
URL: https://github.com/apache/dolphinscheduler/pull/16609#discussion_r1796467943
##########
docs/docs/en/security-model.md:
##########
@@ -0,0 +1,86 @@
+# Apache DolphinScheduler Security Model
Review Comment:
security.md is the part of guide - security.
```suggestion
# Apache DolphinScheduler Security Model
```
Is it inappropriate to put it here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org