You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/09/24 12:38:48 UTC
[GitHub] [dubbo-go-samples] cjphaha opened a new pull request #256: Ftr: custom logger sample
cjphaha opened a new pull request #256:
URL: https://github.com/apache/dubbo-go-samples/pull/256
* 自定义 logger 样例
* custom logger .run 配置文件
* 更新 README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #256: Ftr: custom logger sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-samples/pull/256#discussion_r716017336
##########
File path: logger/README.md
##########
@@ -70,3 +71,28 @@ lumberjackConfig:
# Whether to compress the log file, the compression method is gzip
compress: false
```
+
+#### coustom logger
+
+Custom logger needs to implement the logger interface in the logger package
+
+```go
+type Logger interface {
+ Info(args ...interface{})
+ Warn(args ...interface{})
+ Error(args ...interface{})
+ Debug(args ...interface{})
Review comment:
pls add Fatal()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks merged pull request #256: Ftr: custom logger sample
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #256:
URL: https://github.com/apache/dubbo-go-samples/pull/256
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] cjphaha commented on a change in pull request #256: Ftr: custom logger sample
Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-samples/pull/256#discussion_r716039658
##########
File path: logger/README.md
##########
@@ -70,3 +71,28 @@ lumberjackConfig:
# Whether to compress the log file, the compression method is gzip
compress: false
```
+
+#### coustom logger
+
+Custom logger needs to implement the logger interface in the logger package
+
+```go
+type Logger interface {
+ Info(args ...interface{})
+ Warn(args ...interface{})
+ Error(args ...interface{})
+ Debug(args ...interface{})
+
+ Infof(fmt string, args ...interface{})
+ Warnf(fmt string, args ...interface{})
+ Errorf(fmt string, args ...interface{})
+ Debugf(fmt string, args ...interface{})
Review comment:
This pr has added Fatal() & Fatalf() https://github.com/apache/dubbo-go/pull/1482, Wait for this pr to be merged and then merge this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-samples] AlexStocks commented on a change in pull request #256: Ftr: custom logger sample
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #256:
URL: https://github.com/apache/dubbo-go-samples/pull/256#discussion_r716017371
##########
File path: logger/README.md
##########
@@ -70,3 +71,28 @@ lumberjackConfig:
# Whether to compress the log file, the compression method is gzip
compress: false
```
+
+#### coustom logger
+
+Custom logger needs to implement the logger interface in the logger package
+
+```go
+type Logger interface {
+ Info(args ...interface{})
+ Warn(args ...interface{})
+ Error(args ...interface{})
+ Debug(args ...interface{})
+
+ Infof(fmt string, args ...interface{})
+ Warnf(fmt string, args ...interface{})
+ Errorf(fmt string, args ...interface{})
+ Debugf(fmt string, args ...interface{})
Review comment:
pls add Fatalf()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org