You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2017/11/15 18:16:00 UTC

Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63846/
-----------------------------------------------------------

Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

This test needed to be adapted to the new behaviour of the
built-in executors that are now sending TASK_STARTING
updates.


Diffs
-----

  src/tests/containerizer/port_mapping_tests.cpp 7b0c3e361d5fd66ec8d2a3fa4cc0aece3d1e9d54 


Diff: https://reviews.apache.org/r/63846/diff/1/


Testing
-------

https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2159/


Thanks,

Benno Evers


Re: Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63846/#review191090
-----------------------------------------------------------


Ship it!




Ship It!

- Alexander Rukletsov


On Nov. 15, 2017, 6:15 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63846/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2017, 6:15 p.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test needed to be adapted to the new behaviour of the
> built-in executors that are now sending TASK_STARTING
> updates.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/port_mapping_tests.cpp 7b0c3e361d5fd66ec8d2a3fa4cc0aece3d1e9d54 
> 
> 
> Diff: https://reviews.apache.org/r/63846/diff/1/
> 
> 
> Testing
> -------
> 
> https://jenkins.mesosphere.com/service/jenkins/view/Mesos/job/mesos/job/Mesos_CI-build/2159/
> 
> 
> Thanks,
> 
> Benno Evers
> 
>


Re: Review Request 63846: Updated test PortMappingMesosTest.CGROUPS_ROOT_CleanUpOrphan.

Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63846/
-----------------------------------------------------------

(Updated Nov. 15, 2017, 8:14 p.m.)


Review request for mesos and Alexander Rukletsov.


Repository: mesos


Description
-------

This test needed to be adapted to the new behaviour of the
built-in executors that are now sending TASK_STARTING
updates.


Diffs
-----

  src/tests/containerizer/port_mapping_tests.cpp 7b0c3e361d5fd66ec8d2a3fa4cc0aece3d1e9d54 


Diff: https://reviews.apache.org/r/63846/diff/1/


Testing (updated)
-------

make check on various linux distros


Thanks,

Benno Evers