You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/05/21 12:25:47 UTC

[GitHub] [shardingsphere] DreamerBear opened a new issue #5737: Error message is ambiguous when insert with the Shardingvalue is null

DreamerBear opened a new issue #5737:
URL: https://github.com/apache/shardingsphere/issues/5737


   ## Bug Report
   
   ### Which version of ShardingSphere did you use?
   4.0.0
   
   ### Which project did you use? ShardingSphere-JDBC or ShardingSphere-Proxy?
   ShardingSphere-JDBC
   
   ### Expected behavior
   show appropriate Error message when insert with the Shardingvalue is null
   
   ### Actual behavior
   Error updating database.  Cause: java.lang.IllegalArgumentException: Sharding value must implements Comparable.
   
   ### Reason analyze (If you can)
   Source Code in org.apache.shardingsphere.core.route.router.sharding.condition.engine.InsertClauseShardingConditionEngine.java
   
   `Preconditions.checkArgument(result instanceof Comparable, "Sharding value must implements Comparable.");`
   
   =>
   
   `Preconditions.checkNotNull(result, "Sharding value must not be null");`
   `Preconditions.checkArgument(result instanceof Comparable, "Sharding value must implements Comparable.");`
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on issue #5737: Error message is ambiguous when insert with the Shardingvalue is null

Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5737:
URL: https://github.com/apache/shardingsphere/issues/5737#issuecomment-633921265


   can you fix it and submit a pr?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu edited a comment on issue #5737: Error message is ambiguous when insert with the Shardingvalue is null

Posted by GitBox <gi...@apache.org>.
terrymanu edited a comment on issue #5737:
URL: https://github.com/apache/shardingsphere/issues/5737#issuecomment-641790690


   Closed because of nobody interest about this issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on issue #5737: Error message is ambiguous when insert with the Shardingvalue is null

Posted by GitBox <gi...@apache.org>.
terrymanu commented on issue #5737:
URL: https://github.com/apache/shardingsphere/issues/5737#issuecomment-641790690


   Closed because nobody interest about this issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu closed issue #5737: Error message is ambiguous when insert with the Shardingvalue is null

Posted by GitBox <gi...@apache.org>.
terrymanu closed issue #5737:
URL: https://github.com/apache/shardingsphere/issues/5737


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org