[GitHub] starpit commented on issue #104: Dynamically setting the memory limit of the Nodejs VM

[GitBox <gi...@apache.org>]

starpit commented on issue #104: Dynamically setting the memory limit of the Nodejs VM
URL: https://github.com/apache/incubator-openwhisk-runtime-nodejs/pull/104#issuecomment-457620029
 
 
   if we go with this, the `init.sh` scripts should have `exec node ...` rather than just `node`, so that we aren't left with an extra bash process running around
   
   this seems reasonable... but i thought that the default heap size was quite a bit larger. 1.75GB or so (assuming we are using 64-bit builds of node). if anything, i would think that size is too high, leading to the issues @rabbah alluded to in his `./gc` comment --- if a function is executed relatively infrequently, it will be routinely quiesced, leaving few active cycles for the gc to do its work.
   
   what cgroup quota is allotted to containers these days? if it's higher than 1.75GB, than this PR would result in a change for large memory consumers, at the risk of limiting remaining space for file i/o and the like.
   
   so: it's probably relatively safe, but it does introduce a (small) risk we haven't had before?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services