You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/08/06 18:21:32 UTC

[GitHub] [incubator-mxnet] kshitij12345 commented on a change in pull request #15768: Fix gradient tensor mutate in `adam_update`.

kshitij12345 commented on a change in pull request #15768: Fix gradient tensor mutate in `adam_update`.
URL: https://github.com/apache/incubator-mxnet/pull/15768#discussion_r311208061
 
 

 ##########
 File path: src/operator/optimizer_op.cu
 ##########
 @@ -261,8 +261,7 @@ NNVM_REGISTER_OP(ftml_update)
 .set_attr<FCompute>("FCompute<gpu>", FTMLUpdate<gpu>);
 
 NNVM_REGISTER_OP(adam_update)
-.set_attr<FCompute>("FCompute<gpu>", AdamUpdate<gpu>)
-.set_attr<FComputeEx>("FComputeEx<gpu>", AdamUpdateEx<gpu>);
 
 Review comment:
   Oops. I don't think we should remove it. Had removed it temporarily. Will undo it.
   
   Thanks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services