You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/11/17 06:11:23 UTC

[GitHub] [superset] rusackas commented on a change in pull request #17427: refactor(monorepo): stage 1

rusackas commented on a change in pull request #17427:
URL: https://github.com/apache/superset/pull/17427#discussion_r750908091



##########
File path: superset-frontend/src/dashboard/components/PublishedStatus/PublishedStatus.test.tsx
##########
@@ -30,15 +30,17 @@ const defaultProps = {
 };
 
 test('renders with unpublished status and readonly permissions', async () => {
-  const tooltip = /This dashboard is not published which means it will not show up in the list of dashboards/;
+  const tooltip =
+    /This dashboard is not published which means it will not show up in the list of dashboards/;

Review comment:
       We should use `t()` here (and probably a million other plces)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org