[jira] [Comment Edited] (SLING-7074) RRD4J improve configuration handling

["Alex Deparvu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140014#comment-16140014 ] 

Alex Deparvu edited comment on SLING-7074 at 8/24/17 1:17 PM:
--------------------------------------------------------------

bq. IIUC the activate would throw an exception if I remove the path configuration entry. What do you think about a fallback to the default path in that case?
good point. I was covered for null, but not for empty strings. I've updated the patch to cover this as well: [^SLING-7074-v2.patch]

[~rombert] would you mind taking a look at the patch and applying some of that committer magic if it looks good? :)


was (Author: alex.parvulescu):
bq. IIUC the activate would throw an exception if I remove the path configuration entry. What do you think about a fallback to the default path in that case?
good point. I was covered for null, but not for empty strings. I've updated the patch to cover this as well: [^SLING-7074-v2.patch]

> RRD4J improve configuration handling
> ------------------------------------
>
>                 Key: SLING-7074
>                 URL: https://issues.apache.org/jira/browse/SLING-7074
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>            Reporter: Alex Deparvu
>            Priority: Minor
>             Fix For: Commons Metrics RRD4J 1.0.0
>
>         Attachments: SLING-7074.patch, SLING-7074-v2.patch
>
>
> Opened the config manager and deleted all entries
> {noformat}
>   *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)] org.apache.sling.commons.metrics-rrd4j [org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)] The activate method has thrown an exception (java.lang.NullPointerException)
> java.lang.NullPointerException: null
>     at org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
>     at org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> fyi [~mreutegg]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)