[GitHub] [tinkerpop] heljoyLiu commented on a change in pull request #1257: dotnet: add session connection

[GitBox <gi...@apache.org>]

heljoyLiu commented on a change in pull request #1257: dotnet: add session connection
URL: https://github.com/apache/tinkerpop/pull/1257#discussion_r389255096
 
 

 ##########
 File path: gremlin-dotnet/src/Gremlin.Net/Driver/GremlinClient.cs
 ##########
 @@ -58,14 +58,15 @@ public class GremlinClient : IGremlinClient
         ///     A delegate that will be invoked with the <see cref="ClientWebSocketOptions" />
         ///     object used to configure WebSocket connections.
         /// </param>
+        /// <param name="sessionId">The session Id if Gremlin Client in session mode, defaults to null as session-less Client.</param>
         public GremlinClient(GremlinServer gremlinServer, GraphSONReader graphSONReader = null,
             GraphSONWriter graphSONWriter = null, string mimeType = null,
-            Action<ClientWebSocketOptions> webSocketConfiguration = null)
+            Action<ClientWebSocketOptions> webSocketConfiguration = null, string sessionId = null)
 
 Review comment:
   I checked sessionId in document, here is `Guid`, but String request [in code](https://github.com/apache/tinkerpop/blob/master/gremlin-server/src/main/java/org/apache/tinkerpop/gremlin/server/op/session/SessionOpProcessor.java#L210), and it fails when `Guid` in args
   
   ```
   [WARN] OpExecutorHandler - java.util.UUID cannot be cast to java.lang.String
   java.lang.ClassCastException: java.util.UUID cannot be cast to java.lang.String
   	at org.apache.tinkerpop.gremlin.server.op.session.SessionOpProcessor.getSession(SessionOpProcessor.java:203)
   ```
   anything, we should update document or add `UUID` support in `gremlin-server`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services