You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cxf.apache.org by mm...@apache.org on 2007/11/06 05:49:42 UTC
svn commit: r592271 - in /incubator/cxf/trunk/tools/validator/src:
main/java/org/apache/cxf/tools/validator/internal/WSDLRefValidator.java
test/java/org/apache/cxf/tools/validator/internal/WSDLRefValidatorTest.java
Author: mmao
Date: Mon Nov 5 20:49:41 2007
New Revision: 592271
URL: http://svn.apache.org/viewvc?rev=592271&view=rev
Log:
CXF-1169
* Remove the warning messages when there's no service in the wsdl
Modified:
incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSDLRefValidator.java
incubator/cxf/trunk/tools/validator/src/test/java/org/apache/cxf/tools/validator/internal/WSDLRefValidatorTest.java
Modified: incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSDLRefValidator.java
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSDLRefValidator.java?rev=592271&r1=592270&r2=592271&view=diff
==============================================================================
--- incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSDLRefValidator.java (original)
+++ incubator/cxf/trunk/tools/validator/src/main/java/org/apache/cxf/tools/validator/internal/WSDLRefValidator.java Mon Nov 5 20:49:41 2007
@@ -27,6 +27,7 @@
import java.util.List;
import java.util.Map;
import java.util.Set;
+import java.util.logging.Level;
import java.util.logging.Logger;
import javax.wsdl.Binding;
import javax.wsdl.BindingOperation;
@@ -351,7 +352,9 @@
@SuppressWarnings("unchecked")
private void collectValidationPoints() {
if (services.size() == 0) {
- addWarning("WSDL document does not define any services");
+ LOG.log(Level.WARNING, "WSDL document "
+ + this.definition.getDocumentBaseURI() + " does not define any services");
+ //addWarning("WSDL document does not define any services");
portTypeRefNames.addAll(this.definition.getAllPortTypes().keySet());
} else {
collectValidationPointsForBindings();
Modified: incubator/cxf/trunk/tools/validator/src/test/java/org/apache/cxf/tools/validator/internal/WSDLRefValidatorTest.java
URL: http://svn.apache.org/viewvc/incubator/cxf/trunk/tools/validator/src/test/java/org/apache/cxf/tools/validator/internal/WSDLRefValidatorTest.java?rev=592271&r1=592270&r2=592271&view=diff
==============================================================================
--- incubator/cxf/trunk/tools/validator/src/test/java/org/apache/cxf/tools/validator/internal/WSDLRefValidatorTest.java (original)
+++ incubator/cxf/trunk/tools/validator/src/test/java/org/apache/cxf/tools/validator/internal/WSDLRefValidatorTest.java Mon Nov 5 20:49:41 2007
@@ -36,9 +36,7 @@
WSDLRefValidator validator = new WSDLRefValidator(wsdl);
assertFalse(validator.isValid());
ValidationResult results = validator.getValidationResults();
- assertEquals(1, results.getWarnings().size());
- String t = results.getWarnings().pop();
- assertEquals("WSDL document does not define any services", t);
+ assertEquals(0, results.getWarnings().size());
}
@Test
@@ -104,9 +102,7 @@
validator.isValid();
ValidationResult results = validator.getValidationResults();
- assertEquals(1, results.getWarnings().size());
- String t = results.getWarnings().pop();
- assertEquals("WSDL document does not define any services", t);
+ assertEquals(0, results.getWarnings().size());
WSDLRefValidator v = new WSDLRefValidator(wsdl);
v.setSuppressWarnings(true);