You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/25 13:23:18 UTC
[GitHub] [fineract] Wandji69 opened a new pull request #1111: FINERACT-1012:Spring Security OAuth 2.x to Spring Security 5.2.x
Wandji69 opened a new pull request #1111:
URL: https://github.com/apache/fineract/pull/1111
## Description
Describe the changes made and why they were made. Ignore if these details are present on the associated Jira ticket
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Commit message starts with the issue number from https://issues.apache.org/jira/projects/FINERACT/. Ex: FINERACT-646 Pockets API.
- [x] Coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions have been followed.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
- [ ] Integration tests have been created/updated for verifying the changes made.
- [ ] All Integrations tests are passing with the new commits.
- [x] Submission is not a "code dump". (Large changes can be made "in the repository" via a branch. Ask on the list.)
Our guidelines for code reviews is at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] closed pull request #1111: FINERACT-1012:Spring Security OAuth 2.x to Spring Security 5.2.x
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #1111:
URL: https://github.com/apache/fineract/pull/1111
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1111: FINERACT-1012:Spring Security OAuth 2.x to Spring Security 5.2.x
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1111:
URL: https://github.com/apache/fineract/pull/1111#issuecomment-664061592
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] maektwain commented on pull request #1111: FINERACT-1012:Spring Security OAuth 2.x to Spring Security 5.2.x
Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #1111:
URL: https://github.com/apache/fineract/pull/1111#issuecomment-649981478
Did you test this locally before pushing it? I don't think this is possible since you have to upgrade the dependency did you do it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] maektwain commented on pull request #1111: FINERACT-1012:Spring Security OAuth 2.x to Spring Security 5.2.x
Posted by GitBox <gi...@apache.org>.
maektwain commented on pull request #1111:
URL: https://github.com/apache/fineract/pull/1111#issuecomment-649994116
Just tested your config you cannot put the @Bean circular bean referencing issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org