You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/28 13:02:00 UTC

[jira] [Commented] (MINIFICPP-271) Unncessary Boost dependency in ProcessSession.h

    [ https://issues.apache.org/jira/browse/MINIFICPP-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16223485#comment-16223485 ] 

ASF GitHub Bot commented on MINIFICPP-271:
------------------------------------------

Github user phrocker commented on a diff in the pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/159#discussion_r147553895
  
    --- Diff: libminifi/include/core/ProcessSession.h ---
    @@ -19,7 +19,6 @@
     #define __PROCESS_SESSION_H__
     
     #include <uuid/uuid.h>
    -#include <boost/filesystem.hpp>
    --- End diff --
    
    @dtrodrigues thanks for this. I think I let this slip through in a PR despite trying to eliminate boost for those that don't want it. Thanks for catching this and the contribution. I'll get this merged. 


> Unncessary Boost dependency in ProcessSession.h
> -----------------------------------------------
>
>                 Key: MINIFICPP-271
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-271
>             Project: NiFi MiNiFi C++
>          Issue Type: Bug
>            Reporter: Dustin Rodrigues
>
> There's an unnecessary header file included for Boost in ProcessSession.h causing build errors on OSX.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)