You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/07/23 00:49:27 UTC
[jira] [Commented] (HBASE-12030) Wrong compaction report and assert
when MOB compaction switches to minor
[ https://issues.apache.org/jira/browse/HBASE-12030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14637838#comment-14637838 ]
Hudson commented on HBASE-12030:
--------------------------------
FAILURE: Integrated in HBase-TRUNK #6672 (See [https://builds.apache.org/job/HBase-TRUNK/6672/])
HBASE-12030 Wrong compaction report and assert when MOB compaction switches to minor. (anoopsamjohn: rev a0d9e18ccf3842395a410a6c966f108ab2f55473)
* hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMobCompaction.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/CompactionRequest.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/DefaultCompactor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HMobStore.java
> Wrong compaction report and assert when MOB compaction switches to minor
> ------------------------------------------------------------------------
>
> Key: HBASE-12030
> URL: https://issues.apache.org/jira/browse/HBASE-12030
> Project: HBase
> Issue Type: Bug
> Components: Compaction, regionserver
> Affects Versions: hbase-11339
> Reporter: Matteo Bertozzi
> Assignee: Anoop Sam John
> Priority: Critical
> Fix For: hbase-11339
>
> Attachments: HBASE-12030-V2.diff, HBASE-12030.patch, HBASE-12030_V3.patch
>
>
> when zookeeper is down during a major compaction or a sweep tool run in progress, we switch to a minor.
> {code}
> try {
> zk = MobZookeeper.newInstance(this.conf, compactionName);
> } catch (KeeperException e) {
> LOG.error("Cannot connect to the zookeeper, ready to perform the minor compaction instead", e);
> // change the major compaction into a minor one
> compaction.getRequest().setIsMajor(false);
> return super.compact(compaction);
> }
> {code}
> but the "request start" (HRegion.reportCompactionRequestStart) is "major" and increments the major-compactions counter
> while the "request end" (HRegion.reportCompactionRequestEnd) is "minor" and decrements the minor-compactions counter
> triggering the assert newValue >= 0, since we are decrementing the wrong counter
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)