You are viewing a plain text version of this content. The canonical link for it is here.
Posted to user@nutch.apache.org by Rui Gao <ga...@163.com> on 2013/08/06 16:15:04 UTC
Parameter 'depth' is still supported in 2.2.1?
Hi,
Before 2.1, I use parameter 'depth'. Do we still have such parameter in 2.2.1? I see there is a parameter 'numberOfRounds', does it replace the parameter 'depth'?
Regards,
Rui
Re:Re: Re: Re: Parameter 'depth' is still supported in 2.2.1?
Posted by Rui Gao <ga...@163.com>.
Done.
At 2013-08-08 10:40:19,"Lewis John Mcgibbney" <le...@gmail.com> wrote:
>You don't need to commit, you only need to create a patch and attach it to
>the issue you open on Jira ;)
>Some like this
>* open an issue here - https://issues.apache.org/jira/browse/NUTCH
>* describe in as much detail what the issue is about and fill in all
>required fields to the best of your ability
>* make changes to your code. Best to do svn update so you are working with
>branches/2.x HEAD
>* create a patch - svn diff > ${ISSUE_NUMBER}.patch
>* attach the patch
>
>we will review and commit if it is OK.
>Thanks
>Lewis
>
>
>On Wed, Aug 7, 2013 at 7:34 PM, Rui Gao <ga...@163.com> wrote:
>
>> Hi,
>>
>> I would like to do that, but it seems I don't have permission to commit
>> the code. Could someone give me the access? Thanks.
>>
>>
>> Rui
>>
>>
>>
>>
>>
>>
>> At 2013-08-08 10:30:21,"Lewis John Mcgibbney" <le...@gmail.com>
>> wrote:
>> >Hi Rui,
>> >Please open a Jira for this and patch up 2.3-SNAPSHOT if you are able.
>> >You are right, it's probably about time to get ride of the class and entry
>> >within the bin/nutch script... or at atleast to log a HUGE WARN message
>> >when the class is invoked to say that it is deprecated and should not be
>> >used.
>> >
>> >
>> >On Wed, Aug 7, 2013 at 7:27 PM, Rui Gao <ga...@163.com> wrote:
>> >
>> >> In that case, I think we could remove the whole class Crawler to make
>> >> things clear.
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >>
>> >> At 2013-08-07 01:05:19,"Sebastian Nagel" <wa...@googlemail.com>
>> >> wrote:
>> >> >Hi Rui,
>> >> >
>> >> >yes,
>> >> >- depth (in deprecated class o.a.n.crawl.Crawler) and
>> >> >- numberOfRounds (in bin/crawl)
>> >> >mean the same.
>> >> >
>> >> >Sebastian
>> >> >
>> >> >On 08/06/2013 04:15 PM, Rui Gao wrote:
>> >> >> Hi,
>> >> >>
>> >> >> Before 2.1, I use parameter 'depth'. Do we still have such parameter
>> in
>> >> 2.2.1? I see there is a parameter 'numberOfRounds', does it replace
>> the
>> >> parameter 'depth'?
>> >> >>
>> >> >>
>> >> >> Regards,
>> >> >> Rui
>> >> >>
>> >> >
>> >>
>> >
>> >
>> >
>> >--
>> >*Lewis*
>>
>
>
>
>--
>*Lewis*
Re: Re: Re: Parameter 'depth' is still supported in 2.2.1?
Posted by Lewis John Mcgibbney <le...@gmail.com>.
You don't need to commit, you only need to create a patch and attach it to
the issue you open on Jira ;)
Some like this
* open an issue here - https://issues.apache.org/jira/browse/NUTCH
* describe in as much detail what the issue is about and fill in all
required fields to the best of your ability
* make changes to your code. Best to do svn update so you are working with
branches/2.x HEAD
* create a patch - svn diff > ${ISSUE_NUMBER}.patch
* attach the patch
we will review and commit if it is OK.
Thanks
Lewis
On Wed, Aug 7, 2013 at 7:34 PM, Rui Gao <ga...@163.com> wrote:
> Hi,
>
> I would like to do that, but it seems I don't have permission to commit
> the code. Could someone give me the access? Thanks.
>
>
> Rui
>
>
>
>
>
>
> At 2013-08-08 10:30:21,"Lewis John Mcgibbney" <le...@gmail.com>
> wrote:
> >Hi Rui,
> >Please open a Jira for this and patch up 2.3-SNAPSHOT if you are able.
> >You are right, it's probably about time to get ride of the class and entry
> >within the bin/nutch script... or at atleast to log a HUGE WARN message
> >when the class is invoked to say that it is deprecated and should not be
> >used.
> >
> >
> >On Wed, Aug 7, 2013 at 7:27 PM, Rui Gao <ga...@163.com> wrote:
> >
> >> In that case, I think we could remove the whole class Crawler to make
> >> things clear.
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >>
> >> At 2013-08-07 01:05:19,"Sebastian Nagel" <wa...@googlemail.com>
> >> wrote:
> >> >Hi Rui,
> >> >
> >> >yes,
> >> >- depth (in deprecated class o.a.n.crawl.Crawler) and
> >> >- numberOfRounds (in bin/crawl)
> >> >mean the same.
> >> >
> >> >Sebastian
> >> >
> >> >On 08/06/2013 04:15 PM, Rui Gao wrote:
> >> >> Hi,
> >> >>
> >> >> Before 2.1, I use parameter 'depth'. Do we still have such parameter
> in
> >> 2.2.1? I see there is a parameter 'numberOfRounds', does it replace
> the
> >> parameter 'depth'?
> >> >>
> >> >>
> >> >> Regards,
> >> >> Rui
> >> >>
> >> >
> >>
> >
> >
> >
> >--
> >*Lewis*
>
--
*Lewis*
Re:Re: Re: Parameter 'depth' is still supported in 2.2.1?
Posted by Rui Gao <ga...@163.com>.
Hi,
I would like to do that, but it seems I don't have permission to commit the code. Could someone give me the access? Thanks.
Rui
At 2013-08-08 10:30:21,"Lewis John Mcgibbney" <le...@gmail.com> wrote:
>Hi Rui,
>Please open a Jira for this and patch up 2.3-SNAPSHOT if you are able.
>You are right, it's probably about time to get ride of the class and entry
>within the bin/nutch script... or at atleast to log a HUGE WARN message
>when the class is invoked to say that it is deprecated and should not be
>used.
>
>
>On Wed, Aug 7, 2013 at 7:27 PM, Rui Gao <ga...@163.com> wrote:
>
>> In that case, I think we could remove the whole class Crawler to make
>> things clear.
>>
>>
>>
>>
>>
>>
>>
>>
>> At 2013-08-07 01:05:19,"Sebastian Nagel" <wa...@googlemail.com>
>> wrote:
>> >Hi Rui,
>> >
>> >yes,
>> >- depth (in deprecated class o.a.n.crawl.Crawler) and
>> >- numberOfRounds (in bin/crawl)
>> >mean the same.
>> >
>> >Sebastian
>> >
>> >On 08/06/2013 04:15 PM, Rui Gao wrote:
>> >> Hi,
>> >>
>> >> Before 2.1, I use parameter 'depth'. Do we still have such parameter in
>> 2.2.1? I see there is a parameter 'numberOfRounds', does it replace the
>> parameter 'depth'?
>> >>
>> >>
>> >> Regards,
>> >> Rui
>> >>
>> >
>>
>
>
>
>--
>*Lewis*
Re: Re: Parameter 'depth' is still supported in 2.2.1?
Posted by Lewis John Mcgibbney <le...@gmail.com>.
Hi Rui,
Please open a Jira for this and patch up 2.3-SNAPSHOT if you are able.
You are right, it's probably about time to get ride of the class and entry
within the bin/nutch script... or at atleast to log a HUGE WARN message
when the class is invoked to say that it is deprecated and should not be
used.
On Wed, Aug 7, 2013 at 7:27 PM, Rui Gao <ga...@163.com> wrote:
> In that case, I think we could remove the whole class Crawler to make
> things clear.
>
>
>
>
>
>
>
>
> At 2013-08-07 01:05:19,"Sebastian Nagel" <wa...@googlemail.com>
> wrote:
> >Hi Rui,
> >
> >yes,
> >- depth (in deprecated class o.a.n.crawl.Crawler) and
> >- numberOfRounds (in bin/crawl)
> >mean the same.
> >
> >Sebastian
> >
> >On 08/06/2013 04:15 PM, Rui Gao wrote:
> >> Hi,
> >>
> >> Before 2.1, I use parameter 'depth'. Do we still have such parameter in
> 2.2.1? I see there is a parameter 'numberOfRounds', does it replace the
> parameter 'depth'?
> >>
> >>
> >> Regards,
> >> Rui
> >>
> >
>
--
*Lewis*
Re:Re: Parameter 'depth' is still supported in 2.2.1?
Posted by Rui Gao <ga...@163.com>.
In that case, I think we could remove the whole class Crawler to make things clear.
At 2013-08-07 01:05:19,"Sebastian Nagel" <wa...@googlemail.com> wrote:
>Hi Rui,
>
>yes,
>- depth (in deprecated class o.a.n.crawl.Crawler) and
>- numberOfRounds (in bin/crawl)
>mean the same.
>
>Sebastian
>
>On 08/06/2013 04:15 PM, Rui Gao wrote:
>> Hi,
>>
>> Before 2.1, I use parameter 'depth'. Do we still have such parameter in 2.2.1? I see there is a parameter 'numberOfRounds', does it replace the parameter 'depth'?
>>
>>
>> Regards,
>> Rui
>>
>
Re: Parameter 'depth' is still supported in 2.2.1?
Posted by Sebastian Nagel <wa...@googlemail.com>.
Hi Rui,
yes,
- depth (in deprecated class o.a.n.crawl.Crawler) and
- numberOfRounds (in bin/crawl)
mean the same.
Sebastian
On 08/06/2013 04:15 PM, Rui Gao wrote:
> Hi,
>
> Before 2.1, I use parameter 'depth'. Do we still have such parameter in 2.2.1? I see there is a parameter 'numberOfRounds', does it replace the parameter 'depth'?
>
>
> Regards,
> Rui
>