[GitHub] [hive] asolimando commented on a change in pull request #3019: HIVE-25929: Let secret config properties to be propagated to Tez

[GitBox <gi...@apache.org>]

asolimando commented on a change in pull request #3019:
URL: https://github.com/apache/hive/pull/3019#discussion_r804854330



##########
File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
##########
@@ -7002,6 +7018,16 @@ public void stripHiddenConfigurations(Configuration conf) {
     HiveConfUtil.stripConfigurations(conf, hiddenSet);
   }
 
+  /**
+   * Strips hidden config entries from configuration, but takes care of entries for execution engines.
+   */
+  public void stripHiddenConfigurationsForExecutionEngines(Configuration conf) {
+    Set<String> propsToBePropagatedToExecEngines = HiveConfUtil.getPropagateToExecutionEnginesList(conf);
+    Set<String> propsToBeStripped = new HashSet<String>(hiddenSet);

Review comment:
       ```suggestion
       Set<String> propsToBeStripped = new HashSet<>(hiddenSet);
   ```
   You should be able to use the diamond operator here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org