You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by matrosov-nikita <gi...@git.apache.org> on 2017/04/17 12:37:07 UTC
[GitHub] cordova-lib pull request #542: Install latest version of plugin in case of u...
GitHub user matrosov-nikita opened a pull request:
https://github.com/apache/cordova-lib/pull/542
Install latest version of plugin in case of using dev cordova version
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### What does this PR do?
Semver couldn't verify if cordova version with prerelease tag satisfies to range specified in engine tag.
This PR removes prereleased tag for comparing with range. It's about `cordova-plugin-inappbrowser` and `cordova-plugin-ms-adal`.
### Checklist
- [ ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [ ] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/matrosov-nikita/cordova-lib check-requirements-with-dev-cordova-version
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/542.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #542
----
commit d70de05ac279255296641693dd19915407b324a2
Author: Nikita Matrosov <v-...@microsoft.com>
Date: 2017-04-17T12:31:36Z
Install latest version of plugin in case of using dev cordova version
Semver couldn't verify if cordova version with prerelease tag satisfies to range specified in engine tag
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/542
@stevengill, I think we should use version from `cordova-lib/package.json` rather than package.json from the application. Quick fix: https://github.com/matrosov-nikita/cordova-lib/commit/7d00ab7226843d736650348da7b29e7e9fbb78a7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/542
Thanks for submitting the pr!
How can I reproduce the problem?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: Install latest version of plugin in case of using de...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-lib/pull/542
# [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=h1) Report
> Merging [#542](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-lib/commit/0d637f2d67a95ef709443eaa9d7481eb14f79b8d?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #542 +/- ##
==========================================
- Coverage 82.42% 82.41% -0.01%
==========================================
Files 68 68
Lines 5462 5465 +3
Branches 1072 1073 +1
==========================================
+ Hits 4502 4504 +2
- Misses 960 961 +1
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=tree) | Coverage \u0394 | |
|---|---|---|
| [cordova-lib/src/cordova/plugin.js](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=tree#diff-Y29yZG92YS1saWIvc3JjL2NvcmRvdmEvcGx1Z2luLmpz) | `89.26% <75%> (-0.16%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `\u0394 = absolute <relative> (impact)`, `� = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=footer). Last update [0d637f2...d70de05](https://codecov.io/gh/apache/cordova-lib/pull/542?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...
Posted by matrosov-nikita <gi...@git.apache.org>.
Github user matrosov-nikita commented on the issue:
https://github.com/apache/cordova-lib/pull/542
@stevengill,
1. install cordova via coho (`cordova -v` outputs `6.5.1-dev (cordova-lib@6.5.1-dev)`)
2. run `cordova plugin add cordova-plugin-inappbrowser`
output:
```
Warning: using prerelease version 6.5.1-dev (cordova-lib@6.5.1-dev)
Unmet project requirements for latest version of cordova-plugin-inappbrowser:
cordova (6.5.1-dev in project, >=3.1.0 required)
Fetching highest version of cordova-plugin-inappbrowser that this project supports: 0.2.2 (latest is 1.7.0)
Saved plugin info for "org.apache.cordova.inappbrowser" to config.xml
```
0.2.2 version is installed rather than latest (1.7.0)
The problem that semver tries to compare cordova version with condition from engine tag using `semver.satisfies('6.5.1-dev', '>=3.1.0')` - it returns `false`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...
Posted by uk-taniyama <gi...@git.apache.org>.
Github user uk-taniyama commented on the issue:
https://github.com/apache/cordova-lib/pull/542
I got same error.
```
Unmet project requirements for latest version of cordova-plugin-inappbrowser:
cordova (1.0.0 in project, >=3.1.0 required)
Fetching highest version of cordova-plugin-inappbrowser that this project supports: 0.2.2 (latest is 1.7.1)
```
This version '1.0.0' is written in my application's package.json.(@plugin.js determinePluginTarget)
So, I try to change package.json's version to '7.0.0' then success.
I think this version MUST be cordova's version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/542
Thanks Nikita! I'll make the same changes and commit it now!
On Tue, May 9, 2017 at 3:22 PM, Nikita Matrosov <no...@github.com>
wrote:
> @stevengill <https://github.com/stevengill>, I think we should use
> version from cordova-lib/package.json rather than package.json from the
> application. Quick fix: matrosov-nikita/cordova-lib@7d00ab7
> <https://github.com/matrosov-nikita/cordova-lib/commit/7d00ab7226843d736650348da7b29e7e9fbb78a7>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-lib/pull/542#issuecomment-300180635>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAKWQF7VBHlR12zLhGauvzEokPu9Abw3ks5r4HacgaJpZM4M_HR6>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib issue #542: CB-12663: Install latest version of plugin in case o...
Posted by stevengill <gi...@git.apache.org>.
Github user stevengill commented on the issue:
https://github.com/apache/cordova-lib/pull/542
I created a new issue for this.
https://issues.apache.org/jira/browse/CB-12773
On Tue, May 9, 2017 at 4:39 AM, uk-taniyama <no...@github.com>
wrote:
> I got same error.
>
> Unmet project requirements for latest version of cordova-plugin-inappbrowser:
> cordova (1.0.0 in project, >=3.1.0 required)
> Fetching highest version of cordova-plugin-inappbrowser that this project supports: 0.2.2 (latest is 1.7.1)
>
> This version '1.0.0' is written in my application's
> package.json.(@plugin.js determinePluginTarget)
> So, I try to change package.json's version to '7.0.0' then success.
>
> I think this version MUST be cordova's version.
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/cordova-lib/pull/542#issuecomment-300045448>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAKWQLuUryMLpKgB51xXC9t5RBYpr9dKks5r39HigaJpZM4M_HR6>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #542: CB-12663: Install latest version of plugin in...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/542
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org