You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/05/08 17:01:48 UTC
[GitHub] [arrow] domoritz opened a new pull request #10275: ARROW-12702: [JS] Update webpack
domoritz opened a new pull request #10275:
URL: https://github.com/apache/arrow/pull/10275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#issuecomment-841727405
I merged master so this should be good to squash and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10275:
URL: https://github.com/apache/arrow/pull/10275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
kou closed pull request #10275:
URL: https://github.com/apache/arrow/pull/10275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#issuecomment-841724164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
domoritz commented on pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#issuecomment-841727405
I merged master so this should be good to squash and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#issuecomment-841724164
@domoritz Could you rebase on master to merge this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#discussion_r628788988
##########
File path: js/gulp/minify-task.js
##########
@@ -62,13 +63,10 @@ const minifyTask = ((cache, commonConfig) => memoizeTask(cache, function minifyJ
minimize: true,
minimizer: [
new TerserPlugin({
- sourceMap: true,
terserOptions: {
ecma: terserLanguageNames[target],
- output: { comments: false, beautify: false },
- compress: { unsafe: true },
- mangle: true,
- safari10: true // <-- works around safari10 bugs, see the "safari10" option here: https://github.com/terser-js/terser#minify-options
Review comment:
Safari 10 is sufficiently old enough that we don't need this anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] domoritz commented on a change in pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
domoritz commented on a change in pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#discussion_r628791135
##########
File path: js/gulp/minify-task.js
##########
@@ -83,7 +81,7 @@ const minifyTask = ((cache, commonConfig) => memoizeTask(cache, function minifyJ
}))({}, {
resolve: { mainFields: [`module`, `main`] },
module: { rules: [{ test: /\.js$/, enforce: `pre`, use: [`source-map-loader`] }] },
- output: { filename: '[name].js', library: mainExport, libraryTarget: `umd`, umdNamedDefine: true },
+ output: { filename: '[name].js', library: mainExport, libraryTarget: `umd`, umdNamedDefine: true, globalObject: 'this' },
Review comment:
No idea why this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #10275: ARROW-12702: [JS] Update webpack and terser
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#issuecomment-841730122
Thanks. I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10275: ARROW-12702: [JS] Update webpack
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10275:
URL: https://github.com/apache/arrow/pull/10275#issuecomment-835430125
https://issues.apache.org/jira/browse/ARROW-12702
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org