You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/04/07 14:50:24 UTC
[GitHub] [skywalking-cli] mrproliu opened a new pull request, #141: Let the eBPF profiling could performs by service level
mrproliu opened a new pull request, #141:
URL: https://github.com/apache/skywalking-cli/pull/141
Follow https://github.com/apache/skywalking/issues/8833
Command screenshots:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
fgksgf commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1092369189
Just find [this](https://github.com/golangci/golangci-lint-action/issues/435#issuecomment-1086174073), updated to v3 works now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] codecov-commenter commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1092366388
# [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/141?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#141](https://codecov.io/gh/apache/skywalking-cli/pull/141?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc540d8) into [master](https://codecov.io/gh/apache/skywalking-cli/commit/60cee4a926a867a7bd934b7f94c9a8517e141608?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (60cee4a) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 27.47% 27.47%
=======================================
Files 20 20
Lines 404 404
=======================================
Hits 111 111
Misses 286 286
Partials 7 7
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/141?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking-cli/pull/141?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e0bb065...fc540d8](https://codecov.io/gh/apache/skywalking-cli/pull/141?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] fgksgf commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
fgksgf commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1092362262
This may be caused by the go version, since we didn't use `setup-go`, the `golangci-lint` action installed go1.18 automatically:
<img width="1044" alt="image" src="https://user-images.githubusercontent.com/26627380/162346493-20a3be03-bc20-4623-9606-9cd1e34065b7.png">
How about adding a step before `golangci-lint`:
```yaml
- uses: actions/setup-go@v3
with:
go-version: 1.16
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] mrproliu commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1091849772
> So, you have implemented this at OAP side(local version), right?
Yes, The rover and OAP side implemented both. I need to update the CLI first, then update the Rover side and close the profiling E2E testing temporarily, and finally, update the OAP side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] wu-sheng commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1091843677
So, you have implemented this at OAP side(local version), right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] mrproliu commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1092366427
@fgksgf It's not working too :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] mrproliu commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1092369664
@fgksgf Yes, I have updated and it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] kezhenxu94 merged pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-cli] mrproliu commented on pull request #141: Let the eBPF profiling could performs by service level
Posted by GitBox <gi...@apache.org>.
mrproliu commented on PR #141:
URL: https://github.com/apache/skywalking-cli/pull/141#issuecomment-1091872504
@kezhenxu94 could you help check on the CI? I have tried it on the local machine and it was successful, the golangci-lint version is the same as the CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org