[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1674: add $invokeAsync

[GitBox <gi...@apache.org>]

justxuewei commented on a change in pull request #1674:
URL: https://github.com/apache/dubbo-go/pull/1674#discussion_r771935119



##########
File path: filter/generic/util.go
##########
@@ -31,13 +31,15 @@ import (
 // isCallingToGenericService check if it calls to a generic service
 func isCallingToGenericService(invoker protocol.Invoker, invocation protocol.Invocation) bool {

Review comment:
       This case is that a plain invocation will be converted to the generic fashion on the filter, e.g. `a plain invocation -> <filter> -> a generic invocation`. The method name of the plain invocation is neither `$invoke` nor `$invokeAsync`, in other words, `invocation.MethodName() != constant.Generic && invocation.MethodName() != constant.GenericAsync`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org