[GitHub] [geode] gesterzhou opened pull request #3262: GEODE-6481: add tests to verify create jdbc mapping should get correc…

["gesterzhou (GitHub)" <gi...@apache.org>]

…t field type

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou commented on pull request #3262: GEODE-6481: add tests to verify create jdbc mapping should get correc…

["gesterzhou (GitHub)" <gi...@apache.org>]

This does not work, but this.reflectionBasedAutoSerializerFactory.create("\\Q" + className + "\\E"); will work.

[ Full content available at: https://github.com/apache/geode/pull/3262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] jchen21 commented on pull request #3262: GEODE-6481: add tests to verify create jdbc mapping should get correc…

["jchen21 (GitHub)" <gi...@apache.org>]

Why do we need to implement `PdxSerializerObject`?

[ Full content available at: https://github.com/apache/geode/pull/3262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] gesterzhou closed pull request #3262: GEODE-6481: add tests to verify create jdbc mapping should get correc…

["gesterzhou (GitHub)" <gi...@apache.org>]

[ pull request closed by gesterzhou ]

[ Full content available at: https://github.com/apache/geode/pull/3262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3262: GEODE-6481: add tests to verify create jdbc mapping should get correc…

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

try changing 'EmployeeNumeric.class.getName()' to: "org.apache.geode.connectors.jdbc.internal.cli.CreateMappingCommandDUnitTest.EmployeeNumeric"
Does that cause it to work without your change of \\$ to \\.?

[ Full content available at: https://github.com/apache/geode/pull/3262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #3262: GEODE-6481: add tests to verify create jdbc mapping should get correc…

["dschneider-pivotal (GitHub)" <gi...@apache.org>]

This change does not look safe to me. Out public contract with the ReflectionBasedAutoSerializer is that users can give it regular expressions that will be used to match class names. In a java regular expression "\$" would mean match a literal "$" character. You are changing it to say match a literal ".". I think your fix to support inner classes is at too low a level. It should have instead been in the code that creates a pattern in the precondition function.
I could be wrong about this. Lets talk about it.

[ Full content available at: https://github.com/apache/geode/pull/3262 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org