You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "epugh (via GitHub)" <gi...@apache.org> on 2023/08/04 20:48:16 UTC
[GitHub] [solr] epugh opened a new pull request, #1826: SOLR-16920: Test full package lifecycle
epugh opened a new pull request, #1826:
URL: https://github.com/apache/solr/pull/1826
https://issues.apache.org/jira/browse/SOLR-16920
# Description
Test the full lifecycle.
# Solution
I am currently pointing to a pretty POC package that isn't in the Apache github as well for testing. It HAS found a bug in the current PackageManager!
# Tests
the unit tests plus bats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #1826: SOLR-16920: Test full package lifecycle
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh merged PR #1826:
URL: https://github.com/apache/solr/pull/1826
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] HoustonPutman commented on pull request #1826: SOLR-16920: Test full package lifecycle
Posted by "HoustonPutman (via GitHub)" <gi...@apache.org>.
HoustonPutman commented on PR #1826:
URL: https://github.com/apache/solr/pull/1826#issuecomment-1673359375
> One more idea, what if we comment out the test, so at least we have it someone wants to run it, but it isn't in the regular path?
I'm +1 to this with a comment stating why the test is not enabled by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1826: SOLR-16920: Test full package lifecycle
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1826:
URL: https://github.com/apache/solr/pull/1826#issuecomment-1669382550
> While I do understand the reasoning, I'm not a big fan of having an integration test rely on connection to the internet...
I totally suspected this would come up.... I also don't love that we are referencing some random package created by some random person too! While the "right" thing is to maybe have some sort of test package that exercises all the aspects of package management, and that is maybe part of Apache Solr as well, I don't really have the energy/interest to go down that path. Are you a 0 or a -1 on this PR? I.e, can we live with it for now or do you think to merge we need to deal with it?
One more idea, what if we comment out the test, so at least we have it someone wants to run it, but it isn't in the regular path?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #1826: SOLR-16920: Test full package lifecycle
Posted by "epugh (via GitHub)" <gi...@apache.org>.
epugh commented on PR #1826:
URL: https://github.com/apache/solr/pull/1826#issuecomment-1668521347
Okay, this is ready for Review! @chatman I'd love a LGTM on the test and the bug fix ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org