You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "rickchengx (via GitHub)" <gi...@apache.org> on 2023/06/09 09:45:42 UTC
[GitHub] [dolphinscheduler] rickchengx commented on a diff in pull request #14315: [Bug] [Master] Workflow keep running when task has no id
rickchengx commented on code in PR #14315:
URL: https://github.com/apache/dolphinscheduler/pull/14315#discussion_r1224097945
##########
dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/runner/WorkflowExecuteRunnable.java:
##########
@@ -199,10 +199,10 @@ public class WorkflowExecuteRunnable implements Callable<WorkflowSubmitStatus> {
private final Map<Long, Integer> errorTaskMap = new ConcurrentHashMap<>();
/**
- * complete task map, taskCode as key, taskInstanceId as value
+ * complete task set
* in a DAG, only one taskInstance per taskCode is valid
*/
- private final Map<Long, Integer> completeTaskMap = new ConcurrentHashMap<>();
+ private final Set<Long> completeTaskSet = Sets.newConcurrentHashSet();
Review Comment:
May I ask why to use `set` rather than `map` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org