You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by merlimat <gi...@git.apache.org> on 2017/05/04 06:48:36 UTC

[GitHub] bookkeeper pull request #136: BOOKKEEPER-1046: Avoid long to Long conversion...

GitHub user merlimat opened a pull request:

    https://github.com/apache/bookkeeper/pull/136

    BOOKKEEPER-1046: Avoid long to Long conversion in OrderedSafeExecutor task submit

    When submitting tasks to an OrderedSafeExecutor, most of the time a ledger id is being passed. Given that the method accepts and Object, the primitive `long` is boxed into a `Long` allocated on the heap.
    
    Added specific method overload to directly accept longs as the key in the OrderedSafeExecutor.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merlimat/bookkeeper executor-long-conversion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/bookkeeper/pull/136.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #136
    
----
commit 5dc3a0bd86115f1f34ec14ec7c452e0096a5177b
Author: Matteo Merli <mm...@yahoo-inc.com>
Date:   2015-05-25T03:57:52Z

    BOOKKEEPER-1046: Avoid long to Long conversion in OrderedSafeExecutor task submit

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #136: BOOKKEEPER-1046: Avoid long to Long conversion in Ord...

Posted by merlimat <gi...@git.apache.org>.
Github user merlimat commented on the issue:

    https://github.com/apache/bookkeeper/pull/136
  
    > can you drop the old method as it is no more used ?
    
    @eolivelli We still use it in Pulsar/ManagedLedger to have tasks in the executor executed in order by topic name 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #136: BOOKKEEPER-1046: Avoid long to Long conversion in Ord...

Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/136
  
    All JUnit tests are passing


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper pull request #136: BOOKKEEPER-1046: Avoid long to Long conversion...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/bookkeeper/pull/136


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] bookkeeper issue #136: BOOKKEEPER-1046: Avoid long to Long conversion in Ord...

Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on the issue:

    https://github.com/apache/bookkeeper/pull/136
  
    Overall is OK for me, one little change
    can you drop the old method as it is no more used ?
    
    `public void submitOrdered(Object orderingKey, SafeRunnable r) {`
    
    BK code does not use it directly, it is an internal class.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---