[jira] [Commented] (DRILL-4919) Fix select count(1) / count(*) on csv with header

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-4919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15820071#comment-15820071 ] 

ASF GitHub Bot commented on DRILL-4919:
---------------------------------------

Github user gparai commented on a diff in the pull request:

    https://github.com/apache/drill/pull/714#discussion_r95721099
  
    --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/compliant/CompliantTextRecordReader.java ---
    @@ -91,6 +96,9 @@ public boolean apply(@Nullable SchemaPath path) {
     
       @Override
       protected List<SchemaPath> getDefaultColumnsToRead() {
    +    if (settings.isHeaderExtractionEnabled()) {
    --- End diff --
    
    Please add a comment describing the change - something similar to your comment 
    > ... currently text files with headers do not support columns syntax, so for these type of files we need to replace empty list of columns with default named column when header extraction is enabled


> Fix select count(1) / count(*) on csv with header
> -------------------------------------------------
>
>                 Key: DRILL-4919
>                 URL: https://issues.apache.org/jira/browse/DRILL-4919
>             Project: Apache Drill
>          Issue Type: Bug
>          Components: Functions - Drill
>    Affects Versions: 1.8.0
>            Reporter: F Méthot
>            Assignee: Arina Ielchiieva
>            Priority: Minor
>             Fix For: Future
>
>
> This happens since  1.8
> Dataset (I used extended char for display purpose) test.csvh:
> a,b,c,d\n
> 1,2,3,4\n
> 5,6,7,8\n
> Storage config:
> "csvh": {
>   "type": "text",
>   "extensions" : [
>       "csvh"
>    ],
>    "extractHeader": true,
>    "delimiter": ","
>   }
> select count(1) from dfs.`test.csvh`
> Error: UNSUPPORTED_OPERATION ERROR: With extractHeader enabled, only header names are supported
> coumn name columns
> column index
> Fragment 0:0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)