You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "uranusjr (via GitHub)" <gi...@apache.org> on 2023/09/12 01:40:09 UTC

[GitHub] [airflow] uranusjr commented on pull request #34279: Refactor: Think positively in providers

uranusjr commented on PR #34279:
URL: https://github.com/apache/airflow/pull/34279#issuecomment-1714838059

   Similar to what Jens said above, I think we should keep the `if not ...: raise` pattern and get rid of the `else` indentation instead. It’s similar to the [guard clause pattern](https://medium.com/lemon-code/guard-clauses-3bc0cd96a2d3) and produces cleaner code imo.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org