[GitHub] [druid] maytasm commented on pull request #11519: Improve query error logging

[GitBox <gi...@apache.org>]

maytasm commented on pull request #11519:
URL: https://github.com/apache/druid/pull/11519#issuecomment-889742469


   > @maytasm can you add a more generic flag such as enableDebugLog or enableVerboseLogging etc.? this way we can use the same flag for similar situations. we could end up with too many flags otherwise. what do you think?
   
   That might be more confusing. A generic flag might not be obvious what the flag is for. For example, normally if you think about wanting debug log or more verbose logging you would change your log level (in your log file) to DEBUG level or TRACE level. So now the user might be confuse on what is the difference between flag such as enableDebugLog or enableVerboseLogging vs. changing log level. Also, you may require different detail logs for different scenario. For example, as someone developing a custom extension with new aggregator vs as a druid operator. A generic flag such as enableDebugLog or enableVerboseLogging that emits details log for one may not be useful at all for the other. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org