[GitHub] [hive] kishendas commented on a change in pull request #1510: Fix ranger issue with permanent UDF

[GitBox <gi...@apache.org>]

kishendas commented on a change in pull request #1510:
URL: https://github.com/apache/hive/pull/1510#discussion_r492564859



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionUtils.java
##########
@@ -126,6 +126,10 @@ public static String qualifyFunctionName(String functionName, String dbName) {
     } else if (names.length > 2) {
       throw new HiveException("Function name does not have correct format: " + functionName);
     }
+    // This is to fix the ranger related issue : HIVE-24182

Review comment:
       Done

##########
File path: ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionUtils.java
##########
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hive.ql.exec;
+
+import org.apache.hadoop.hive.ql.metadata.HiveException;
+import org.junit.Assert;
+import org.junit.Test;
+
+public class TestFunctionUtils {

Review comment:
       Added




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org