You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by MikeThomsen <gi...@git.apache.org> on 2018/05/15 12:46:48 UTC
[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4
GitHub user MikeThomsen opened a pull request:
https://github.com/apache/nifi/pull/2705
NIFI-5169 Upgrade to JSONPath 2.4
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MikeThomsen/nifi NIFI-5169
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2705.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2705
----
commit fae557a2273c440b7c59483a2dfb2f0c062821b7
Author: Mike Thomsen <mi...@...>
Date: 2018-05-15T09:49:45Z
NIFI-5169 Upgrade to JSONPath 2.4
----
---
[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2705
LGTM, +1 FWIW
---
[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2705
@mattyb149 @ottobackwards did a review on this one and approved (but isn't a committer). His judgment is usually spot on if you want to sign off.
---
[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by joewitt <gi...@git.apache.org>.
Github user joewitt commented on the issue:
https://github.com/apache/nifi/pull/2705
+1 merged to master
---
[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by ottobackwards <gi...@git.apache.org>.
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2705#discussion_r188281072
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java ---
@@ -112,10 +111,10 @@ static String getResultRepresentation(Object jsonPathResult, String defaultValue
public ValidationResult validate(final String subject, final String input, final ValidationContext context) {
String error = null;
if (isStale(subject, input)) {
- if (JsonPathExpressionValidator.isValidExpression(input)) {
+ try {
JsonPath compiledJsonPath = JsonPath.compile(input);
cacheComputedValue(subject, input, compiledJsonPath);
--- End diff --
This throws an IllegalArgumentException if the input is null, and an InvalidPathException if the compile is wrong. Maybe we should catch the explicit exception? This is a nit I know.
---
[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2705#discussion_r188393536
--- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java ---
@@ -112,10 +111,10 @@ static String getResultRepresentation(Object jsonPathResult, String defaultValue
public ValidationResult validate(final String subject, final String input, final ValidationContext context) {
String error = null;
if (isStale(subject, input)) {
- if (JsonPathExpressionValidator.isValidExpression(input)) {
+ try {
JsonPath compiledJsonPath = JsonPath.compile(input);
cacheComputedValue(subject, input, compiledJsonPath);
--- End diff --
I should have a `isBlank` check there, so good catch.
---
[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2705
---
[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4
Posted by MikeThomsen <gi...@git.apache.org>.
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2705
@joewitt @ottobackwards gave it a +1 and travis likes it. Can you merge?
---