You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Jim Jagielski <ji...@devsys.jaguNET.com> on 1999/03/21 15:27:47 UTC
Re: cvs commit: apache-apr/pthreads/src/main http_main.c http_protocol.c
manoj@hyperreal.org wrote:
>
> manoj 99/03/21 02:42:36
>
> Modified: pthreads/src/main http_main.c http_protocol.c
> Log:
> Make MaxRequestsPerChild work in the threaded server again (well at
> least it works like the process server works). This consists of a few
> changes:
>
> - We need to actually count requests. In the pthreads port, we do this
> by decrementing requests_this_child
Admittedly, I haven't looked at the code but does this work OK when the
user as MaxRequestsPerChild set to 0 (ie: no limit) ?
--
===========================================================================
Jim Jagielski ||| jim@jaguNET.com ||| http://www.jaguNET.com/
"That's no ordinary rabbit... that's the most foul,
cruel and bad-tempered rodent you ever laid eyes on"
Re: cvs commit: apache-apr/pthreads/src/main http_main.c http_protocol.c
Posted by Manoj Kasichainula <ma...@io.com>.
On Sun, Mar 21, 1999 at 09:27:47AM -0500, Jim Jagielski wrote:
> Admittedly, I haven't looked at the code but does this work OK when the
> user as MaxRequestsPerChild set to 0 (ie: no limit) ?
It does. The loop check for this is:
while ((ap_max_requests_per_child != 0 && requests_this_child > 0) ||
(ap_max_requests_per_child == 0)) {
and I just tested it to be sure.
--
Manoj Kasichainula - manojk at io dot com - http://www.io.com/~manojk/
"You can get more with a kind word and a 2x4 then just a kind word."
-- Marcus, B5
Re: cvs commit: apache-apr/pthreads/src/main http_main.c http_protocol.c
Posted by Ryan Bloom <rb...@raleigh.ibm.com>.
Without actually having seen the patch, I can say that this should work.
I put in the correct logic to handle that case a long time ago, and this
patch shouldn't have touched that code. I'll look at it closer tonight or
tomorrow.
Ryan
On Sun, 21 Mar 1999, Jim Jagielski wrote:
> manoj@hyperreal.org wrote:
> >
> > manoj 99/03/21 02:42:36
> >
> > Modified: pthreads/src/main http_main.c http_protocol.c
> > Log:
> > Make MaxRequestsPerChild work in the threaded server again (well at
> > least it works like the process server works). This consists of a few
> > changes:
> >
> > - We need to actually count requests. In the pthreads port, we do this
> > by decrementing requests_this_child
>
> Admittedly, I haven't looked at the code but does this work OK when the
> user as MaxRequestsPerChild set to 0 (ie: no limit) ?
> --
> ===========================================================================
> Jim Jagielski ||| jim@jaguNET.com ||| http://www.jaguNET.com/
> "That's no ordinary rabbit... that's the most foul,
> cruel and bad-tempered rodent you ever laid eyes on"
>
_______________________________________________________________________
Ryan Bloom rbb@raleigh.ibm.com
4205 S Miami Blvd
RTP, NC 27709 It's a beautiful sight to see good dancers
doing simple steps. It's a painful sight to
see beginners doing complicated patterns.