You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/02 02:20:32 UTC
[GitHub] [doris] dutyu opened a new pull request, #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
dutyu opened a new pull request, #14750:
URL: https://github.com/apache/doris/pull/14750
…ics when enable_vectorized_engine=true.
# Proposed changes
Issue Number: close #xxx
## Problem summary
When set enable_vectorized_engine = true, sometimes scanBytes and scanRows is missing in audit log.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [x] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] whutpencil commented on pull request #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
Posted by GitBox <gi...@apache.org>.
whutpencil commented on PR #14750:
URL: https://github.com/apache/doris/pull/14750#issuecomment-1334732435
why the cputimeMS is not added in the method?
`statistics->add_cpu_ms(_scan_cpu_timer->value() / NANOS_PER_MILLIS);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
Posted by GitBox <gi...@apache.org>.
dutyu commented on PR #14750:
URL: https://github.com/apache/doris/pull/14750#issuecomment-1339011629
> > why the cputimeMS is not added in the method?
> > `statistics->add_cpu_ms(_scan_cpu_timer->value() / NANOS_PER_MILLIS);`
>
> It will not work if just add this line at method `collect_query_statistics`, maybe we also need to do some job at `scanner_scheduler.cpp` to update `_scan_cpu_timer`, but i'm not familiar with c++, so i just fix these two fields first. You can submit a new pr to fix this problem.
I've submit a pr to fix CpuTimeMS( [PR-14853](https://github.com/apache/doris/pull/14853) )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dutyu commented on pull request #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
Posted by GitBox <gi...@apache.org>.
dutyu commented on PR #14750:
URL: https://github.com/apache/doris/pull/14750#issuecomment-1334954015
> why the cputimeMS is not added in the method?
>
> `statistics->add_cpu_ms(_scan_cpu_timer->value() / NANOS_PER_MILLIS);`
It will not work if just add this line at method `collect_query_statistics`, maybe we also need to do some job at `scanner_scheduler.cpp` to update `_scan_cpu_timer`, but i'm not familiar with c++, so i just fix these two fields first. You can submit a new pr to fix this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dinggege1024 commented on pull request #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
Posted by GitBox <gi...@apache.org>.
dinggege1024 commented on PR #14750:
URL: https://github.com/apache/doris/pull/14750#issuecomment-1336037240
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14750:
URL: https://github.com/apache/doris/pull/14750#issuecomment-1334721389
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.47 seconds
load time: 510 seconds
storage size: 17123356162 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221202033711_clickbench_pr_56557.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #14750: [fix](statistics) fix missing scanBytes and scanRows in query statist…
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #14750:
URL: https://github.com/apache/doris/pull/14750
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org