You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Caideyipi (via GitHub)" <gi...@apache.org> on 2026/10/20 05:56:50 UTC

[PR] [Subscription][Pipe] Improve receiver error messages and diagnostics [iotdb]

Caideyipi opened a new pull request, #18932:
URL: https://github.com/apache/iotdb/pull/18932

   ## Description
   
   Subscription receiver failures still used hard-coded English response text in Chinese builds. Move missing-consumer, unknown-request, RPC, ConfigNode, and unsupported-seek messages into matching English and Chinese templates.
   
   Legacy Pipe receiver I/O failures logged only exception messages, losing their stack traces. Preserve the exceptions in the logs and return the same formatted diagnostic to the client. File-resolution failures now identify the file, and append failures include the file name, requested offset, and byte count.
   
   Add regression coverage for subscription failure responses and Pipe file-write diagnostics, including the logged exception. Update existing path-validation assertions to work with both locales.
   
   ## Validation
   
   - Full-reactor `mvn -nsu test-compile -DskipTests`, with the default locale and with `-P with-zh-locale`.
   - `SubscriptionReceiverV1Test` and `IoTDBLegacyPipeReceiverAgentTest`: 22 tests passed in each locale. The Chinese test run includes `-am -P with-zh-locale` so reactor dependencies use the same locale.
   - Spotless formatting and `git diff --check`.
   - Verified English/Chinese message-key parity and matching placeholders and deterministic names for all 24 added templates.
   
   This PR has:
   
   - [x] been self-reviewed.
   - [x] added or updated unit tests to cover the affected error responses and logging.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Subscription][Pipe] Improve receiver error messages and diagnostics [iotdb]

Posted by "jt2594838 (via GitHub)" <gi...@apache.org>.
jt2594838 merged PR #18932:
URL: https://github.com/apache/iotdb/pull/18932


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org