[GitHub] [hbase] virajjasani commented on a change in pull request #1835: HBASE-24446 Use EnvironmentEdgeManager to compute clock skew in Master

[GitBox <gi...@apache.org>]

virajjasani commented on a change in pull request #1835:
URL: https://github.com/apache/hbase/pull/1835#discussion_r435449031



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/ServerManager.java
##########
@@ -78,13 +75,18 @@
 import org.apache.hadoop.hbase.regionserver.RegionOpeningState;
 import org.apache.hadoop.hbase.security.User;
 import org.apache.hadoop.hbase.util.Bytes;
+import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
 import org.apache.hadoop.hbase.util.RetryCounter;
 import org.apache.hadoop.hbase.util.RetryCounterFactory;
 import org.apache.hadoop.hbase.util.Triple;
 import org.apache.hadoop.hbase.zookeeper.ZKUtil;
 import org.apache.hadoop.hbase.zookeeper.ZooKeeperWatcher;
 import org.apache.zookeeper.KeeperException;
 
+import com.google.common.annotations.VisibleForTesting;
+import com.google.protobuf.ByteString;
+import com.google.protobuf.ServiceException;
+

Review comment:
       @sguggilam looks like import order is incorrect as per checkstyle error:
   ```
   ServerManager.java:86:import com.google.common.annotations.VisibleForTesting;: Wrong order for 'com.google.common.annotations.VisibleForTesting' import. [ImportOrder]
   ```
   Maybe you can put these import in their original place, (could be IDE settings issue)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org