[GitHub] [airflow] whynick1 commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process

[GitBox <gi...@apache.org>]

whynick1 commented on a change in pull request #8090: [AIRFLOW-7118] Honor schema type for mysql to gcs data pre-process
URL: https://github.com/apache/airflow/pull/8090#discussion_r406601342
 
 

 ##########
 File path: airflow/providers/google/cloud/operators/mysql_to_gcs.py
 ##########
 @@ -102,10 +102,12 @@ def field_to_bigquery(self, field):
     def convert_type(self, value, schema_type):
         """
         Takes a value from MySQLdb, and converts it to a value that's safe for
-        JSON/Google Cloud Storage/BigQuery. Dates are converted to UTC seconds.
-        Decimals are converted to floats. Binary type fields are encoded with base64,
-        as imported BYTES data must be base64-encoded according to Bigquery SQL
-        date type documentation: https://cloud.google.com/bigquery/data-types
+        JSON/Google Cloud Storage/BigQuery. Datetimes are converted to UTC seconds.
 
 Review comment:
   Done! Can I get another review please? 😃 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services