[oak-core] offset and count parameters in NodeState.getChildNodeEntries

[Michael Dürig <md...@apache.org>]

Hi,

Is there a uses case for having offset and count parameters in 
NodeState.getChildNodeEntries (package 
org.apache.jackrabbit.oak.spi.state)? The only one I can see is to do 
lazy reading from the Microkernel. This can however also be done 
implicitly by the implementation of getChildNodeEntries() instead of 
explicitly by the API consumer.

These parameters are troublesome since they make decorating NodeState 
instances to filter out certain child node entries difficult to 
implement. In fact any such implementation would need to explicitly 
iterate through up to the offset supplied which make the whole thing 
pointless.

If no one objects, I'll remove these parameters and adapt 
KernelNodeState to take care of lazy reading.

Michael

Re: [oak-core] offset and count parameters in NodeState.getChildNodeEntries

[Michael Dürig <md...@apache.org>]

On 2.5.12 13:31, Jukka Zitting wrote:
> Hi,
>
> On Wed, May 2, 2012 at 1:17 PM, Michael Dürig<md...@apache.org>  wrote:
>> If no one objects, I'll remove these parameters and adapt KernelNodeState to
>> take care of lazy reading.
>
> Sounds OK to me.

See https://issues.apache.org/jira/browse/OAK-81.

Michael

>
> BR,
>
> Jukka Zitting

Re: [oak-core] offset and count parameters in NodeState.getChildNodeEntries

[Jukka Zitting <ju...@gmail.com>]

Hi,

On Wed, May 2, 2012 at 1:17 PM, Michael Dürig <md...@apache.org> wrote:
> If no one objects, I'll remove these parameters and adapt KernelNodeState to
> take care of lazy reading.

Sounds OK to me.

BR,

Jukka Zitting