You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/04/12 16:50:13 UTC

[GitHub] [trafficcontrol] rawlinp commented on a diff in pull request #6544: Layered profile `servers/` API {GET, POST, PUT & DELETE}

rawlinp commented on code in PR #6544:
URL: https://github.com/apache/trafficcontrol/pull/6544#discussion_r848655840


##########
lib/go-tc/servers.go:
##########
@@ -700,6 +700,44 @@ type CommonServerProperties struct {
 	XMPPPasswd       *string              `json:"xmppPasswd" db:"xmpp_passwd"`
 }
 
+type CommonServerPropertiesV40 struct {

Review Comment:
   I leave the decision up to you, Rima -- I generally prefer option B, but I'm not hung up on it. Since the plan is to eventually cleanly remove API v3, the duplication is temporary (or, _should_ be temporary at least).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org