You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "zeroshade (via GitHub)" <gi...@apache.org> on 2023/04/21 19:38:37 UTC
[GitHub] [arrow] zeroshade opened a new pull request, #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
zeroshade opened a new pull request, #35276:
URL: https://github.com/apache/arrow/pull/35276
### What changes are included in this PR?
A simple check in the struct reader to validate that we're trying to read something with at least one child before we start trying to build a nullbitmap that wouldn't exist if there are 0 elements in the actual array.
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
### Are these changes tested?
Yes a unit test is included in this change.
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35276:
URL: https://github.com/apache/arrow/pull/35276#issuecomment-1536759599
Benchmark runs are scheduled for baseline = c2f7d13e16c4ec3c8fba551a157cd71398194e6f and contender = 6608347d61b047987c29542002663fe02cb5158e. 6608347d61b047987c29542002663fe02cb5158e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/a61c45100a4c4a2db3ebc1dcfafb7f27...7cbfe0d0d3f9405a9dc0abac8d66f053/)
[Failed :arrow_down:3.89% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/6c36efabe1134daeb1c8780421b3488e...1165f0945686410583a6cd76ac30dc89/)
[Finished :arrow_down:0.51% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ed055ad299f8482ebded456dad5fd0bb...9a6a63a2ff8e4e138be83610d98d668b/)
[Failed :arrow_down:0.0% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/7896e023c68c4929be862bda6668cfec...c07a156f3b2747eebd364f168d4d8fd7/)
Buildkite builds:
[Finished] [`6608347d` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2822)
[Failed] [`6608347d` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2859)
[Finished] [`6608347d` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2822)
[Failed] [`6608347d` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2849)
[Finished] [`c2f7d13e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2821)
[Failed] [`c2f7d13e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2858)
[Finished] [`c2f7d13e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2821)
[Failed] [`c2f7d13e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2848)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on PR #35276:
URL: https://github.com/apache/arrow/pull/35276#issuecomment-1518710788
@emkornfield the read crashes inside of Def Levels to Bitmap because the leaf array has no elements despite there being 1 record because it's an empty list.
The initialization of the bitmap writer attempts to grab a reference to the first byte of the bitmap, but because `lenBound` was 0, we resized the buffer to 0 bytes, so it tries to read byte 0 of an empty slice. It's definitely possible the C++ impl has this same issue, i haven't checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "emkornfield (via GitHub)" <gi...@apache.org>.
emkornfield commented on PR #35276:
URL: https://github.com/apache/arrow/pull/35276#issuecomment-1518577288
Which part crashes without this check? I wonder if c++ has this issue as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35276:
URL: https://github.com/apache/arrow/pull/35276#issuecomment-1518259883
:warning: GitHub issue #35202 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade merged pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade merged PR #35276:
URL: https://github.com/apache/arrow/pull/35276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35276:
URL: https://github.com/apache/arrow/pull/35276#issuecomment-1518259842
* Closes: #35202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35276: GH-35202: [Go][Parquet] Fix panic reading nested empty list
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35276:
URL: https://github.com/apache/arrow/pull/35276#issuecomment-1536759989
['Python', 'R'] benchmarks have high level of regressions.
[test-mac-arm](https://conbench.ursa.dev/compare/runs/6c36efabe1134daeb1c8780421b3488e...1165f0945686410583a6cd76ac30dc89/)
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ed055ad299f8482ebded456dad5fd0bb...9a6a63a2ff8e4e138be83610d98d668b/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org