[GitHub] [incubator-devlake] abeizn commented on a diff in pull request #6064: refactor: syncPolicy timeAfter

["abeizn (via GitHub)" <gi...@apache.org>]

abeizn commented on code in PR #6064:
URL: https://github.com/apache/incubator-devlake/pull/6064#discussion_r1324062164


##########
backend/core/runner/run_task.go:
##########
@@ -54,8 +54,16 @@ func RunTask(
 		return err
 	}
 	syncPolicy := &models.SyncPolicy{}
-	syncPolicy.SkipOnFail = dbPipeline.SkipOnFail
-	syncPolicy.FullSync = dbPipeline.FullSync
+	blueprint := &models.Blueprint{}

Review Comment:
   fixed



##########
backend/plugins/ae/ae.go:
##########
@@ -30,12 +30,13 @@ func main() {
 	aeCmd := &cobra.Command{Use: "ae"}
 	connectionId := aeCmd.Flags().Uint64P("Connection-id", "c", 0, "ae connection id")
 	projectId := aeCmd.Flags().IntP("project-id", "p", 0, "ae project id")
+	timeAfter := aeCmd.Flags().StringP("timeAfter", "a", "", "collect data that are created after specified time, ie 2006-01-02T15:04:05Z")

Review Comment:
   fixed



##########
backend/plugins/bamboo/bamboo.go:
##########
@@ -31,6 +31,7 @@ func main() {
 	bambooCmd := &cobra.Command{Use: "bamboo"}
 	connectionId := bambooCmd.Flags().Uint64P("Connection-id", "c", 0, "bamboo connection id")
 	projectKey := bambooCmd.Flags().StringP("project-key", "p", "", "bamboo project key")
+	timeAfter := bambooCmd.Flags().StringP("timeAfter", "a", "", "collect data that are created after specified time, ie 2006-01-02T15:04:05Z")

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org