You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Jørgen Løland (JIRA)" <ji...@apache.org> on 2007/05/10 08:52:15 UTC

[jira] Created: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Authorization error codes have been moved. Translated messages must be moved accordingly.
-----------------------------------------------------------------------------------------

                 Key: DERBY-2633
                 URL: https://issues.apache.org/jira/browse/DERBY-2633
             Project: Derby
          Issue Type: Sub-task
          Components: JDBC
    Affects Versions: 10.3.0.0
            Reporter: Jørgen Løland
         Assigned To: Jørgen Løland


The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495533 ] 

Knut Anders Hatlen commented on DERBY-2633:
-------------------------------------------

Thanks Jørgen! The patch looks good to me. I'll run the regression tests and commit.

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-1828-and-2633-2.diff, DERBY-1828-and-2633-2.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495618 ] 

Jørgen Løland commented on DERBY-2633:
--------------------------------------

Thank you for reviewing and committing the patch, Knut

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-1828-and-2633-2.diff, DERBY-1828-and-2633-2.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland closed DERBY-2633.
--------------------------------


> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-1828-and-2633-2.diff, DERBY-1828-and-2633-2.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Knut Anders Hatlen resolved DERBY-2633.
---------------------------------------

       Resolution: Fixed
    Fix Version/s: 10.3.0.0
       Derby Info:   (was: [Patch Available])

Committed revision 537850.

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-1828-and-2633-2.diff, DERBY-1828-and-2633-2.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2633:
---------------------------------

    Derby Info: [Patch Available]

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2633:
---------------------------------

    Derby Info: [Patch Available]

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-1828-and-2633-2.diff, DERBY-1828-and-2633-2.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2633:
---------------------------------

    Attachment: DERBY-1828-and-2633-2.stat
                DERBY-1828-and-2633-2.diff

The patch (DERBY-1828-and-2633-2) addresses the build error. Suites.All and derbyall runs cleanly except ProcedureInTriggerTest, which is a recurring error and likely unrelated. 

The only difference from patch (1) is that AUTHORIZATION_PREFIX is replaced by AUTHORIZATION_SPEC_PREFIX in java/client/org/apache/derby/client/am/SQLExceptionFactory40.java

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-1828-and-2633-2.diff, DERBY-1828-and-2633-2.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2633:
---------------------------------

    Derby Info:   (was: [Patch Available])

I see now that I never used JDK 1.6, hence the build completed without errors. I will report back with a new patch once I have run the tests once more.

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Knut Anders Hatlen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12495365 ] 

Knut Anders Hatlen commented on DERBY-2633:
-------------------------------------------

I see this build failure after applying the DERBY-1828-and-2633-1.diff patch:

compile_jdbc4:
    [javac] Compiling 17 source files to /export/home/kh160127/derby/sandbox/1828+2633/classes
    [javac] /export/home/kh160127/derby/sandbox/1828+2633/java/client/org/apache/derby/client/am/SQLExceptionFactory40.java:75: cannot find symbol
    [javac] symbol  : variable AUTHORIZATION_PREFIX
    [javac] location: interface org.apache.derby.shared.common.reference.SQLState
    [javac]         } else if (sqlState.startsWith(SQLState.AUTHORIZATION_PREFIX)) {
    [javac]                                                ^
    [javac] 1 error

BUILD FAILED

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2633:
---------------------------------

    Attachment: DERBY-2633-1.diff
                DERBY-2633-1.stat

The patch (DERBY-2633-1) is stripped of modifications found in 1828-2indent. Use this patch if DERBY-1828 is committed standalone. The patch cannot be tested since the 1828 modifications are required.

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat, DERBY-2633-1.diff, DERBY-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12494969 ] 

Jørgen Løland commented on DERBY-2633:
--------------------------------------

The patch (1) fails ProcedureInTriggerTest testTriggerNegative, which is a recurring error. I think this is unrelated. Apart from that, derbyall and suites.all runs cleanly.

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (DERBY-2633) Authorization error codes have been moved. Translated messages must be moved accordingly.

Posted by "Jørgen Løland (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/DERBY-2633?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jørgen Løland updated DERBY-2633:
---------------------------------

    Attachment: DERBY-1828-and-2633-1.stat
                DERBY-1828-and-2633-1.diff

The patch (DERBY-1828-and-2633-1) contains patch 2indent of DERBY-1828 and the required changes to translated languages. Since only the error codes are changed, no translated messages have been deleted. They only have a new error code and a new location in the message_*.properties files.

> Authorization error codes have been moved. Translated messages must be moved accordingly.
> -----------------------------------------------------------------------------------------
>
>                 Key: DERBY-2633
>                 URL: https://issues.apache.org/jira/browse/DERBY-2633
>             Project: Derby
>          Issue Type: Sub-task
>          Components: JDBC
>    Affects Versions: 10.3.0.0
>            Reporter: Jørgen Løland
>         Assigned To: Jørgen Løland
>         Attachments: DERBY-1828-and-2633-1.diff, DERBY-1828-and-2633-1.stat
>
>
> The patch for DERBY-1828 changes the error codes of a number of authorization failures, and changes the english error messages accordingly. The translated messages have to be changed to reflect the error code modifications.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.