You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@groovy.apache.org by Jochen Theodorou <bl...@gmx.org> on 2016/09/06 21:23:24 UTC
Re: progress on executing tests with JDK9 status update
Another update on JDK9...
I now managed to make the last groovy-core tests running! I used
jigsaw-132 for the test.
Doing a full Groovy build, the only part missing now is the tests in
groovysh. There
org.codehaus.groovy.tools.shell.util.PackageHelperImplTest multiple
times and I have not yet investigated why. I also did not test the indy
version of the build yet.
bye Jochen
Re: progress on executing tests with JDK9 status update
Posted by Guillaume Laforge <gl...@gmail.com>.
Great progress!
Le mardi 6 septembre 2016, Jochen Theodorou <bl...@gmx.org> a écrit :
> Another update on JDK9...
>
> I now managed to make the last groovy-core tests running! I used
> jigsaw-132 for the test.
>
> Doing a full Groovy build, the only part missing now is the tests in
> groovysh. There org.codehaus.groovy.tools.shell.util.PackageHelperImplTest
> multiple times and I have not yet investigated why. I also did not test the
> indy version of the build yet.
>
> bye Jochen
>
>
>
--
Guillaume Laforge
Apache Groovy committer & PMC Vice-President
Developer Advocate @ Google Cloud Platform
Blog: http://glaforge.appspot.com/
Social: @glaforge <http://twitter.com/glaforge> / Google+
<https://plus.google.com/u/0/114130972232398734985/posts>
Re: progress on executing tests with JDK9 status update
Posted by Thibault Kruse <ti...@googlemail.com>.
In that case sorry for the misinformation. Sorry I won't have time to look
at the last failing test.
On Thursday, September 8, 2016, John Wagenleitner <
john.wagenleitner@gmail.com> wrote:
> On Wed, Sep 7, 2016 at 11:55 AM, Jochen Theodorou <blackdrag@gmx.org
> <javascript:_e(%7B%7D,'cvml','blackdrag@gmx.org');>> wrote:
>
>> On 07.09.2016 19:54, John Wagenleitner wrote:
>>
>>> On Wed, Sep 7, 2016 at 8:50 AM, Jochen Theodorou <blackdrag@gmx.org
>>> <javascript:_e(%7B%7D,'cvml','blackdrag@gmx.org');>
>>> <mailto:blackdrag@gmx.org
>>> <javascript:_e(%7B%7D,'cvml','blackdrag@gmx.org');>>> wrote:
>>>
>>>
>>>
>>> On 07.09.2016 14:33, Thibault Kruse wrote:
>>>
>>> The groovysh tests failed last because the strategy to read
>>> package
>>> contents via the ClassLoader does not work with Java8. Possibly
>>> checking how the new Java REPL does things could reveal a
>>> solution, if
>>> they do have tab completion for imports. In the meantime, I'd
>>> suggest
>>> skipping those tests when testing with Java9. Not having
>>> completion
>>> for imports in groovysh with Java9 should probably not be
>>> critical.
>>>
>>>
>>> How about basing this on the classpath property instead? That is
>>> what I did for 90% of the other failing tests
>>>
>>>
>>>
>>> All of the groovysh tests pass for me using build 9-ea+134-jigsaw.
>>>
>>
>>
>> really? that would be strange since I did see getResource calls to find
>> .class files and it was said, that this is not supported anymore in
>> JDK9/jigsaw.... and then again, I can confirm that everything works with
>> ea+134-jigsaw. Strange. I also tested the indy version of the build, and
>> everything seems to work fine.
>>
>> Nice!
>>
>> bye Jochen
>>
>>
>>
>>
>
> There was special jigsaw handling added [1]. For a span of builds it
> wasn't working but as of the recent builds I think some fixes to the jrt
> filesystem were fixed so now it passes. After the recent changes now there
> is just one failing Swing test.
>
> [1] https://github.com/apache/groovy/blob/d1fdc38c2c2c0539b434326b37b813
> 328ced96a4/subprojects/groovy-groovysh/src/main/groovy/org/
> codehaus/groovy/tools/shell/util/PackageHelperImpl.groovy#L118-L122
>
Re: progress on executing tests with JDK9 status update
Posted by John Wagenleitner <jo...@gmail.com>.
On Wed, Sep 7, 2016 at 11:55 AM, Jochen Theodorou <bl...@gmx.org> wrote:
> On 07.09.2016 19:54, John Wagenleitner wrote:
>
>> On Wed, Sep 7, 2016 at 8:50 AM, Jochen Theodorou <blackdrag@gmx.org
>> <ma...@gmx.org>> wrote:
>>
>>
>>
>> On 07.09.2016 14:33, Thibault Kruse wrote:
>>
>> The groovysh tests failed last because the strategy to read
>> package
>> contents via the ClassLoader does not work with Java8. Possibly
>> checking how the new Java REPL does things could reveal a
>> solution, if
>> they do have tab completion for imports. In the meantime, I'd
>> suggest
>> skipping those tests when testing with Java9. Not having
>> completion
>> for imports in groovysh with Java9 should probably not be
>> critical.
>>
>>
>> How about basing this on the classpath property instead? That is
>> what I did for 90% of the other failing tests
>>
>>
>>
>> All of the groovysh tests pass for me using build 9-ea+134-jigsaw.
>>
>
>
> really? that would be strange since I did see getResource calls to find
> .class files and it was said, that this is not supported anymore in
> JDK9/jigsaw.... and then again, I can confirm that everything works with
> ea+134-jigsaw. Strange. I also tested the indy version of the build, and
> everything seems to work fine.
>
> Nice!
>
> bye Jochen
>
>
>
>
There was special jigsaw handling added [1]. For a span of builds it
wasn't working but as of the recent builds I think some fixes to the jrt
filesystem were fixed so now it passes. After the recent changes now there
is just one failing Swing test.
[1]
https://github.com/apache/groovy/blob/d1fdc38c2c2c0539b434326b37b813328ced96a4/subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/util/PackageHelperImpl.groovy#L118-L122
Re: progress on executing tests with JDK9 status update
Posted by Jochen Theodorou <bl...@gmx.org>.
On 07.09.2016 19:54, John Wagenleitner wrote:
> On Wed, Sep 7, 2016 at 8:50 AM, Jochen Theodorou <blackdrag@gmx.org
> <ma...@gmx.org>> wrote:
>
>
>
> On 07.09.2016 14:33, Thibault Kruse wrote:
>
> The groovysh tests failed last because the strategy to read package
> contents via the ClassLoader does not work with Java8. Possibly
> checking how the new Java REPL does things could reveal a
> solution, if
> they do have tab completion for imports. In the meantime, I'd
> suggest
> skipping those tests when testing with Java9. Not having completion
> for imports in groovysh with Java9 should probably not be critical.
>
>
> How about basing this on the classpath property instead? That is
> what I did for 90% of the other failing tests
>
>
>
> All of the groovysh tests pass for me using build 9-ea+134-jigsaw.
really? that would be strange since I did see getResource calls to find
.class files and it was said, that this is not supported anymore in
JDK9/jigsaw.... and then again, I can confirm that everything works with
ea+134-jigsaw. Strange. I also tested the indy version of the build, and
everything seems to work fine.
Nice!
bye Jochen
Re: progress on executing tests with JDK9 status update
Posted by John Wagenleitner <jo...@gmail.com>.
On Wed, Sep 7, 2016 at 8:50 AM, Jochen Theodorou <bl...@gmx.org> wrote:
>
>
> On 07.09.2016 14:33, Thibault Kruse wrote:
>
>> The groovysh tests failed last because the strategy to read package
>> contents via the ClassLoader does not work with Java8. Possibly
>> checking how the new Java REPL does things could reveal a solution, if
>> they do have tab completion for imports. In the meantime, I'd suggest
>> skipping those tests when testing with Java9. Not having completion
>> for imports in groovysh with Java9 should probably not be critical.
>>
>
> How about basing this on the classpath property instead? That is what I
> did for 90% of the other failing tests
>
>
All of the groovysh tests pass for me using build 9-ea+134-jigsaw.
Re: progress on executing tests with JDK9 status update
Posted by Jochen Theodorou <bl...@gmx.org>.
On 07.09.2016 14:33, Thibault Kruse wrote:
> The groovysh tests failed last because the strategy to read package
> contents via the ClassLoader does not work with Java8. Possibly
> checking how the new Java REPL does things could reveal a solution, if
> they do have tab completion for imports. In the meantime, I'd suggest
> skipping those tests when testing with Java9. Not having completion
> for imports in groovysh with Java9 should probably not be critical.
How about basing this on the classpath property instead? That is what I
did for 90% of the other failing tests
bye Jochen
Re: progress on executing tests with JDK9 status update
Posted by Thibault Kruse <ti...@googlemail.com>.
The groovysh tests failed last because the strategy to read package
contents via the ClassLoader does not work with Java8. Possibly
checking how the new Java REPL does things could reveal a solution, if
they do have tab completion for imports. In the meantime, I'd suggest
skipping those tests when testing with Java9. Not having completion
for imports in groovysh with Java9 should probably not be critical.
On Wed, Sep 7, 2016 at 6:23 AM, Jochen Theodorou <bl...@gmx.org> wrote:
> Another update on JDK9...
>
> I now managed to make the last groovy-core tests running! I used jigsaw-132
> for the test.
>
> Doing a full Groovy build, the only part missing now is the tests in
> groovysh. There org.codehaus.groovy.tools.shell.util.PackageHelperImplTest
> multiple times and I have not yet investigated why. I also did not test the
> indy version of the build yet.
>
> bye Jochen
>
>