You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/06/30 19:06:40 UTC

[GitHub] [beam] ajamato commented on a change in pull request #12130: [BEAM-10381] Increase retries in pull_licenses_java.py from 3 to 9.

ajamato commented on a change in pull request #12130:
URL: https://github.com/apache/beam/pull/12130#discussion_r447916417



##########
File path: sdks/java/container/license_scripts/pull_licenses_java.py
##########
@@ -39,7 +39,7 @@
 from urllib.request import urlopen, URLError, HTTPError
 
 SOURCE_CODE_REQUIRED_LICENSES = ['lgpl', 'glp', 'cddl', 'mpl']
-RETRY_NUM = 3
+RETRY_NUM = 9

Review comment:
       I suggest we use wait_fixed(5) instead of the wait_exponential. Since we were only setting retries to 3 before it should have been waiting:
   2s, 4s, 8s.
   
   wait_fixed(5) will spend about a minute max on each url. I don't want to make it wait much more. I believe the test will time out if we make it too long.
   wait: 5s, 5s, 5s, 5s, 5s, 5s, 5s, 5s, 5s
   
   I suggest we try this first. WDYT? Here are the tenacity docs:
   https://tenacity.readthedocs.io/en/latest/




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org