[GitHub] [pinot] KKcorps commented on pull request #10703: Add delete support to upsert tables

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on PR #10703:
URL: https://github.com/apache/pinot/pull/10703#issuecomment-1529415252

   Should the `queryableDocIdSnapshot` needs to be persisted as well on shutdown for this to work?
   
   Also, `queryableDocId` sounds confusing because `validDocId` is also used for querying. I think we should rename it to `activeRowIds` or `undeletedRowIds`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org