You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by is...@cocoondev.org on 2005/06/01 13:02:55 UTC

[JIRA] Created: (FOR-514) Do not limit status.xml contexts in project info plugin

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-514

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-514
    Summary: Do not limit status.xml contexts in project info plugin
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Plugin: projectInfo

   Assignee: 
   Reporter: Ross Gardler

    Created: Wed, 1 Jun 2005 6:02 AM
    Updated: Wed, 1 Jun 2005 6:02 AM

Description:
(This comment brought over from FOR-487)

This improvement of changes page is nice.

I have my own version based on xsl:key definition in order to be able to simply manage as many contexts as you can define (My Dtd is not limited to "build|docs|code|admin|design".

The advantage - on my opinion - is that my own contexts are very various and not developpement oriented nor language dependant.
here a short example - using releaseNote... :
        http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html

The following code replace the 5 blocks <xsl:if test="action[@context='build']"> :

   <title>Version <xsl:value-of select="@version"/> (<xsl:value-of select="@date"/>)</title>
+ <xsl:for-each select="action[generate-id()=generate-id(key('contextes',concat(../@version, '_', @context)))]">
+ <xsl:sort select="@context"/>
+ <section>
+ <title><xsl:value-of select="@context"/></title>
+ <ul>
+ <xsl:apply-templates select="key('contextes',concat(../@version, '_', @context) )">
+ <xsl:sort select="@type"/>
+ </xsl:apply-templates>
+ </ul>
+ </section>
+ </xsl:for-each>

Hope you'll like the idea...

Regards,
Cyriaque,


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[JIRA] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Ross Gardler
    Created: Wed, 1 Jun 2005 6:07 AM
       Body:
In one sense you change is a big improvement on my original code. However, it prevents the ability to add a meningful title to each section since the title becomes the value of the context attribute.

Perhaps we can provide an (optional) lookup table in the status.xml file that will give a title, for example:

<status>
  <actionContexts>
    <context id="code" description="Changes to the Code Base">
    <context id="docs" description="Changes to the Documentation">
  </action>
  ...
<status>

If no entry is found for //actionContexts/context[@id="CONTEXT"] then we would use the @id value in titles otherwise we would use //actionContexts/context[@id="CONTEXT"]/@description

In later versions this would allow for internationalisation of the status contexts.

WDYT?

[NB try to submite changes as patched, it makes it much easier for us to apply and therefore increases the chance of it being applied in a timely fashion. If you don't know how ask us on the dev list.]
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-514?page=comments#action_12460

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-514

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-514
    Summary: Do not limit status.xml contexts in project info plugin
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Plugin: projectInfo

   Assignee: 
   Reporter: Ross Gardler

    Created: Wed, 1 Jun 2005 6:02 AM
    Updated: Wed, 1 Jun 2005 6:07 AM

Description:
(This comment brought over from FOR-487)

This improvement of changes page is nice.

I have my own version based on xsl:key definition in order to be able to simply manage as many contexts as you can define (My Dtd is not limited to "build|docs|code|admin|design".

The advantage - on my opinion - is that my own contexts are very various and not developpement oriented nor language dependant.
here a short example - using releaseNote... :
        http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html

The following code replace the 5 blocks <xsl:if test="action[@context='build']"> :

   <title>Version <xsl:value-of select="@version"/> (<xsl:value-of select="@date"/>)</title>
+ <xsl:for-each select="action[generate-id()=generate-id(key('contextes',concat(../@version, '_', @context)))]">
+ <xsl:sort select="@context"/>
+ <section>
+ <title><xsl:value-of select="@context"/></title>
+ <ul>
+ <xsl:apply-templates select="key('contextes',concat(../@version, '_', @context) )">
+ <xsl:sort select="@type"/>
+ </xsl:apply-templates>
+ </ul>
+ </section>
+ </xsl:for-each>

Hope you'll like the idea...

Regards,
Cyriaque,


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[JIRA] Commented: (FOR-514) Do not limit status.xml contexts in project info plugin

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Cyriaque Dupoirieux
    Created: Wed, 1 Jun 2005 8:45 AM
       Body:
Good Ross,

I can work on it with your idea :
<actionContexts>
    <context id="code" description="Changes to the Code Base">
    <context id="docs" description="Changes to the Documentation">
</actionContexts>

And I will send a patch.

By the way, I could not - in my previous comment - send a patch because the issue were closed... (that's why I send a code sample in the text...)
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-514?page=comments#action_12462

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-514

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-514
    Summary: Do not limit status.xml contexts in project info plugin
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Plugin: projectInfo

   Assignee: 
   Reporter: Ross Gardler

    Created: Wed, 1 Jun 2005 6:02 AM
    Updated: Wed, 1 Jun 2005 8:45 AM

Description:
(This comment brought over from FOR-487)

This improvement of changes page is nice.

I have my own version based on xsl:key definition in order to be able to simply manage as many contexts as you can define (My Dtd is not limited to "build|docs|code|admin|design".

The advantage - on my opinion - is that my own contexts are very various and not developpement oriented nor language dependant.
here a short example - using releaseNote... :
        http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html

The following code replace the 5 blocks <xsl:if test="action[@context='build']"> :

   <title>Version <xsl:value-of select="@version"/> (<xsl:value-of select="@date"/>)</title>
+ <xsl:for-each select="action[generate-id()=generate-id(key('contextes',concat(../@version, '_', @context)))]">
+ <xsl:sort select="@context"/>
+ <section>
+ <title><xsl:value-of select="@context"/></title>
+ <ul>
+ <xsl:apply-templates select="key('contextes',concat(../@version, '_', @context) )">
+ <xsl:sort select="@type"/>
+ </xsl:apply-templates>
+ </ul>
+ </section>
+ </xsl:for-each>

Hope you'll like the idea...

Regards,
Cyriaque,


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[JIRA] Updated: (FOR-514) Do not limit status.xml contexts in project info plugin

Posted by is...@cocoondev.org.
The following issue has been updated:

    Updater: Cyriaque Dupoirieux (mailto:Cyriaque.Dupoirieux@pcotech.fr)
       Date: Fri, 3 Jun 2005 7:41 AM
    Comment:
- Udpate of the Status DTD 1.3 in order to be able to add the following information :
   <actionContexts>
    <context id="code" title="Changes to the Code Base"/>
    <context id="docs" title="Changes to the Documentation"/>
    <!-- ... -->
   </actionContexts> 

- Update of changes2document.xsl in order to take into account the context title or by default the context ID.
- Update of status.xml files (with documentation associated in comments)

Regards,
Cyriaque,
    Changes:
             Attachment changed to patch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://issues.cocoondev.org//browse/FOR-514?page=history

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-514

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-514
    Summary: Do not limit status.xml contexts in project info plugin
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Plugin: projectInfo

   Assignee: 
   Reporter: Ross Gardler

    Created: Wed, 1 Jun 2005 6:02 AM
    Updated: Fri, 3 Jun 2005 7:41 AM

Description:
(This comment brought over from FOR-487)

This improvement of changes page is nice.

I have my own version based on xsl:key definition in order to be able to simply manage as many contexts as you can define (My Dtd is not limited to "build|docs|code|admin|design".

The advantage - on my opinion - is that my own contexts are very various and not developpement oriented nor language dependant.
here a short example - using releaseNote... :
        http://cyriaque.dupoirieux.free.fr/changes_6.2.1.html

The following code replace the 5 blocks <xsl:if test="action[@context='build']"> :

   <title>Version <xsl:value-of select="@version"/> (<xsl:value-of select="@date"/>)</title>
+ <xsl:for-each select="action[generate-id()=generate-id(key('contextes',concat(../@version, '_', @context)))]">
+ <xsl:sort select="@context"/>
+ <section>
+ <title><xsl:value-of select="@context"/></title>
+ <ul>
+ <xsl:apply-templates select="key('contextes',concat(../@version, '_', @context) )">
+ <xsl:sort select="@type"/>
+ </xsl:apply-templates>
+ </ul>
+ </section>
+ </xsl:for-each>

Hope you'll like the idea...

Regards,
Cyriaque,


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira