You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/14 19:47:13 UTC

[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35819: [SPARK-38524][K8S][TESTS] Fix Volcano `weight` to be positive integer and use `cpu` capability instead

dongjoon-hyun commented on a change in pull request #35819:
URL: https://github.com/apache/spark/pull/35819#discussion_r826319420



##########
File path: resource-managers/kubernetes/integration-tests/src/test/resources/volcano/disable-queue.yml
##########
@@ -19,6 +19,6 @@ kind: Queue
 metadata:
   name: queue
 spec:
-  weight: 0
+  weight: 1
   capability:
-    cpu: "1"
+    cpu: "0.1"

Review comment:
       `cpu: 0` is also invalid by definition?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org