[GitHub] [helix] desaikomal commented on a diff in pull request #2470: code clean up - debug log format

["desaikomal (via GitHub)" <gi...@apache.org>]

desaikomal commented on code in PR #2470:
URL: https://github.com/apache/helix/pull/2470#discussion_r1181979972


##########
helix-agent/src/main/java/org/apache/helix/agent/AgentStateModel.java:
##########
@@ -148,8 +148,8 @@ public void genericStateTransitionHandler(Message message, NotificationContext c
     // + " output:\n" + externalCmd.getStringOutput());
 
     if (_logger.isDebugEnabled()) {

Review Comment:
   you need to remove this line.



##########
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java:
##########
@@ -130,12 +130,12 @@ public IdealState computeNewIdealState(String resourceName,
         .computePartitionAssignment(allNodes, liveNodes, currentMapping, clusterData);
 
     if (LOG.isDebugEnabled()) {

Review Comment:
   this is not required



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org