[GitHub] dubeejw commented on a change in pull request #2847: Treat action code as attachments for created/updated actions

[GitBox <gi...@apache.org>]

dubeejw commented on a change in pull request #2847: Treat action code as attachments for created/updated actions
URL: https://github.com/apache/incubator-openwhisk/pull/2847#discussion_r153325540
 
 

 ##########
 File path: common/scala/src/main/scala/whisk/core/entity/Exec.scala
 ##########
 @@ -278,21 +278,33 @@ protected[core] object Exec extends ArgNormalizer[Exec] with DefaultJsonProtocol
 
           manifest.attached
             .map { a =>
-              val jar: Attachment[String] = {
-                // java actions once stored the attachment in "jar" instead of "code"
-                obj.fields.get("code").orElse(obj.fields.get("jar"))
+              // java actions once stored the attachment in "jar" instead of "code"
+              val code = obj.fields.get("code").orElse(obj.fields.get("jar"))
 
 Review comment:
   As part of https://github.com/apache/incubator-openwhisk/pull/2938 I have normalized jar to code. Will have to remove the jar reference here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services