[GitHub] [helix] qqu0127 commented on a diff in pull request #2353: Implement direct child change listener in ZkMetaClient

["qqu0127 (via GitHub)" <gi...@apache.org>]

qqu0127 commented on code in PR #2353:
URL: https://github.com/apache/helix/pull/2353#discussion_r1094670696


##########
meta-client/src/main/java/org/apache/helix/metaclient/impl/zk/ZkMetaClient.java:
##########
@@ -258,7 +260,12 @@ public boolean subscribeDataChange(String key, DataChangeListener listener,
   public DirectChildSubscribeResult subscribeDirectChildChange(String key,
       DirectChildChangeListener listener, boolean skipWatchingNonExistNode,
       boolean persistListener) {

Review Comment:
   For the API level change, let's make it a separate PR? Either it's 1 or 2 API, it can be refactored fairly easily after this one is checked in. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org