You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2026/06/13 01:17:03 UTC

[I] Add timeout and retry to DatasetFileDocument file-service requests [texera]

Ma77Ball opened a new issue, #5666:
URL: https://github.com/apache/texera/issues/5666

   ### Task Summary
   `DatasetFileDocument` (`amber/src/main/python/pytexera/storage/dataset_file_document.py`) makes two `requests.get()` calls, the presigned-URL fetch in `get_presigned_url` and the file download in `read_file`, with no `timeout`. Since `requests` defaults to no timeout, a slow, hung, or unreachable file-service blocks the worker thread indefinitely, with no recovery from transient network blips. Add a request timeout and a bounded retry policy so these calls fail in bounded time and ride out transient connection errors / 5xx responses. Both calls are idempotent GETs, so retrying is safe.
   ### Task Type
   - [x] Performance


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add timeout and retry to DatasetFileDocument file-service requests [texera]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on issue #5666:
URL: https://github.com/apache/texera/issues/5666#issuecomment-4696917446

   <!-- texera:template-compliance -->
   👋 Thanks for opening this issue, @Ma77Ball!
   
   It looks like the issue description doesn't quite follow our template yet:
   
   - This issue doesn't appear to use one of our templates (Bug, Feature, or Task). Please open it using a template so the required details are captured.
   
   Filling out the template helps reviewers understand and triage your contribution faster. Please edit the description to complete it. This message will disappear automatically once the template is followed.
   
   You can find the template prompts by editing the description, or see [CONTRIBUTING.md](https://github.com/apache/texera/blob/main/CONTRIBUTING.md) for the full contribution flow.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add timeout and retry to DatasetFileDocument file-service requests [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang closed issue #5666: Add timeout and retry to DatasetFileDocument file-service requests
URL: https://github.com/apache/texera/issues/5666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add timeout and retry to DatasetFileDocument file-service requests [texera]

Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.

Ma77Ball commented on issue #5666:
URL: https://github.com/apache/texera/issues/5666#issuecomment-4703782289

   > why do we need those timeouts? are they hanging?
   
   Yes, I've hit it locally: when the file-service stalls, `requests.get()` has no default timeout so the worker blocks on the read forever. Rare (haven't seen others repro it), but real.
   
   The timeout is a no-response guard (resets on each byte, so slow downloads are fine) and the retry reconnects after a stall. Both are idempotent GETs, so retry is safe.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Add timeout and retry to DatasetFileDocument file-service requests [texera]

Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.

Yicong-Huang commented on issue #5666:
URL: https://github.com/apache/texera/issues/5666#issuecomment-4702501561

   why do we need those timeouts? are they hanging?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org