[GitHub] [pulsar] sijie commented on a change in pull request #9628: [Pulsar SQL] Add max split entry queue size bytes limitation

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #9628:
URL: https://github.com/apache/pulsar/pull/9628#discussion_r580065578



##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/CacheSizeAllocator.java
##########
@@ -0,0 +1,65 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pulsar.sql.presto;
+
+import java.util.concurrent.atomic.AtomicLong;
+import org.eclipse.jetty.util.AtomicBiInteger;
+
+/**
+ * Cache size allocator.
+ */
+public class CacheSizeAllocator {
+
+    private final long maxCacheSize;
+    private final AtomicLong availableCacheSize;

Review comment:
       Use LongAdder?

##########
File path: pulsar-sql/presto-pulsar/src/main/java/org/apache/pulsar/sql/presto/PulsarRecordCursor.java
##########
@@ -136,6 +137,10 @@ public PulsarRecordCursor(List<PulsarColumnHandle> columnHandles, PulsarSplit pu
                         pulsarConnectorConfig),
                 new PulsarConnectorMetricsTracker(pulsarConnectorCache.getStatsProvider()));
         this.decoderFactory = decoderFactory;
+        if (pulsarConnectorConfig.getMaxSplitEntryQueueSizeBytes() >= 0) {
+            this.entryCacheSizeAllocator = new CacheSizeAllocator(

Review comment:
       I think you can make it an interface. Then have a no-op implementation and a CacheSizeAllocator implementation. Then you don't need to add `if (entryCacheSizeAllocator != null)` everywhere else.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org